fix: let otp errors propogate to prevent redirects

sylv · sylv · commit e56d700d2ed9 · 2024-02-26T03:39:22.000+08:00
diff --git a/packages/web/src/containers/login-form.tsx b/packages/web/src/containers/login-form.tsx
@@ -56,7 +56,7 @@ export const LoginForm: FC = () => {
 
   if (user.otpRequired && loginInfo) {
     return (
-      <div>
+      <div className="w-full">
         <OtpInput
           loading={loggingIn}
           invalid={invalidOTP}
diff --git a/packages/web/src/hooks/useUser.tsx b/packages/web/src/hooks/useUser.tsx
@@ -48,7 +48,6 @@ export const useLoginUser = () => {
     } else if (result.error) {
       if (result.error.message.toLowerCase().includes('otp')) {
         setOtp(true);
-        return;
       }
 
       throw result.error;

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,6 @@ export const useLoginUser = () => {`
`48`	`48`	`} else if (result.error) {`
`49`	`49`	`if (result.error.message.toLowerCase().includes('otp')) {`
`50`	`50`	`setOtp(true);`
`51`		`- return;`
`52`	`51`	`}`
`53`	`52`
`54`	`53`	`throw result.error;`