adding tag\name for a rule

[avishni01]

hello

i have just start using the module instead of creating with the basic terraform resources. it took me time to use it correctly , but one thing is missing (or maybe i didn't find how to do it), naming the SG rules. the name is actully bases on the tag Name, vurrntly in the default view all rules are displayed with empty name , there should be an option to add tags and name to for each rule.

[FlorinAndrei]

Yeah, there might be issues when names are conflicting with each other, but this would be very useful. I actually found this ticket because I was looking for a way to tag or describe the rules.

[ScubaDrew]

This module is not that great. Adding/Changing rules never works correctly either.

[tigpt]

I also wanted to add tags to the SG Rules, but looking at hashicorp/aws and hashicorp/awscc this is not exposed in api yet, so we can't do this for the module.

Looking forward to be able to track SG Rules with Tags to make sure every SG Rule is terraform and not clicksops.

[robertalexa]

According to documentation, it think it is just a case of using a different resource for rules
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/security_group_rule

Please note the first note:

I interpret that as the module (this as well as others e.g. ecs) to drop the use of aws_security_group_rule and switch to aws_vpc_security_group_egress_rule and aws_vpc_security_group_ingress_rule respectively.

Wondering if maybe @antonbabenko or @bryantbiggs know anything on this or are tracking this on their roadmap already.

[github-actions]

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

[tomasz-baran]

not stale

[tigpt]

We need to upgrade to aws_vpc_security_group_ingress_rule and to aws_vpc_security_group_ingress_rule in order to use tags on the SG rules. If I want to detect drifts in sg rules I normally use AWS Tag Editor to export all resources tags that miss "terraform=true" but the SG rules can't implement tags with the current resource aws_security_group_rule.

As documentation an upgrade from aws_security_group_rule to aws_vpc_security_group_*gress_rule is recommended.

[github-actions]

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

[elstak]

not stale 👍

[github-actions]

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days