Allow list of cidr_blocks instead of just one when create custom rules.

[TayTTo]

I think we could let the cidr_blocks in ingress_with_cird_blocks is list of string because if I need to apply one rule in different cidr, it will be duplicated.

[beatenstratblues]

can you please give a little more insight into the issue? Like with this proposed idea, are we trying to make sure we can apply the same rule to multiple cidr_blocks? instead of having to create it multiple times for different cidr_blocks?

[TayTTo]

@beatenstratblues I mean, it will be better if they let the cidr_blocks as list, because maybe we will need custom rules in several cidr_blocks, if we cannot create array of cidr_blocks, we will need to write same rule several times in different cidr block.

[tcutts]

While that might work for simple cases, it would be better to add support for using network prefix lists which are designed for this purpose. Where I work, 0.0.0.0/0 ingress rules for ssh are banned, but the list of company network prefixes is quite long. So the company provisions a prefix list into each account with the appropriate list of CIDRs. The AWS terraform module for security groups supports this prefix list, so I think that's the right way to go here rather than creating lots of separate ingress rules for multiple CIDR blocks.

You just need to use 'ingress_prefix_list_ids' instead of 'ingress_cidr_blocks'

[github-actions]

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days