Skip to content

Commit d366283

Browse files
authored
Merge branch 'main' into renovate/major-terraform-dependencies
2 parents 852ebe3 + e4e9aa7 commit d366283

File tree

9 files changed

+16
-19
lines changed

9 files changed

+16
-19
lines changed

.catalog-onboard-pipeline.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22
apiVersion: v1
33
offerings:
44
# below is an example of a Deployable Architecture (DA) solution
5-
- name: deploy-arch-ibm-hpc # must match the offering name in the ibm_catalog.json
5+
- name: deploy-arch-ibm-hpc-lsf # must match the offering name in the ibm_catalog.json
66
kind: solution
7-
catalog_id: 8611e025-10b2-488e-8261-a7f584a5114b
8-
offering_id: bf3c07f8-5a62-4289-8ea0-94dbb2b410e6
7+
catalog_id: 0d89ec0d-d39a-494d-ac5b-9d940d8cc65f
8+
offering_id: 1444e20a-af22-40d1-af98-c880918849cb
99
# list all of the variations (flavors) you have included in the ibm_catalog.json
1010
variations:
1111
- name: Cluster-with-LSF

LSF_DA_New.drawio.svg

Lines changed: 1 addition & 1 deletion
Loading

hpcaas-arch-1.6.svg

Lines changed: 0 additions & 4 deletions
This file was deleted.

ibm_catalog.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -587,7 +587,7 @@
587587
]
588588
},
589589
{
590-
"service_name": "sysdig-secure",
590+
"service_name": "Security and Compliance Center Workload Protection",
591591
"role_crns": [
592592
"crn:v1:bluemix:public:iam::::role:Administrator"
593593
]
@@ -606,7 +606,7 @@
606606
]
607607
},
608608
{
609-
"service_name": "service",
609+
"service_name": "All Identity and Access enabled services",
610610
"role_crns": [
611611
"crn:v1:bluemix:public:iam::::serviceRole:Manager",
612612
"crn:v1:bluemix:public:iam::::role:Administrator"

modules/resource_provisioner/locals.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ locals {
44
deployer_path = "/opt/ibm"
55
remote_terraform_path = format("%s/terraform-ibm-hpc", local.deployer_path)
66
da_hpc_repo_url = "github.com/terraform-ibm-modules/terraform-ibm-hpc.git"
7-
da_hpc_repo_tag = "lsf-da-20-june" ###### change it to main in future
7+
da_hpc_repo_tag = "main"
88
remote_ansible_path = format("%s/ibm-spectrumscale-cloud-deploy", local.deployer_path)
99
scale_cloud_infra_repo_url = "https://github.com/jayeshh123/ibm-spectrum-scale-install-infra"
1010
scale_cloud_infra_repo_name = "ibm-spectrum-scale-install-infra"

samples/configs/hpc_schematics_values.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@
269269
"value": "__NULL__",
270270
"type": "string",
271271
"secure": false,
272-
"description": "Provide the existing kms key name that you want to use for the IBM Cloud HPC cluster. Note: kms_key_name to be considered only if key_management value is set as key_protect.(for example kms_key_name: my-encryption-key)."
272+
"description": "Provide the existing kms key name that you want to use for the IBM Spectrum LSF cluster. Note: kms_key_name to be considered only if key_management value is set as key_protect.(for example kms_key_name: my-encryption-key)."
273273
},
274274
{
275275
"name": "enable_vpc_flow_logs",

solutions/lsf/catalogValidationValues.json.template

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,6 @@
33
"cluster_prefix": $PREFIX,
44
"zones": "[\"ca-tor-1\"]",
55
"existing_resource_group": "geretain-hpc-rg",
6-
"ssh_keys": "[\"geretain-hpc-ssh-key\"]"
6+
"ssh_keys": "[\"geretain-hpc-ssh-key\"]",
7+
"app_center_gui_password": $RAND_PASSWORD
78
}

solutions/lsf/variables.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,7 @@ variable "static_compute_instances" {
298298
)
299299
default = [{
300300
profile = "bx2-4x16"
301-
count = 1
301+
count = 0
302302
image = "hpc-lsf-fp15-compute-rhel810-v1"
303303
}]
304304
description = "Specify the list of static compute node configurations, including instance profile, image name, and count. By default, all compute nodes are created using Fix Pack 15. If deploying with Fix Pack 14, set lsf_version to fixpack_14 and use the corresponding image hpc-lsf-fp14-compute-rhel810-v1. The selected image must align with the specified lsf_version, any mismatch may lead to deployment failures. The solution allows customization of instance profiles and counts, but mixing custom images and IBM stock images across instances is not supported. If using IBM stock images, only Red Hat-based images are allowed."
@@ -475,7 +475,7 @@ variable "kms_instance_name" {
475475
variable "kms_key_name" {
476476
type = string
477477
default = null
478-
description = "Provide the existing kms key name that you want to use for the IBM Cloud HPC cluster. Note: kms_key_name to be considered only if key_management value is set as key_protect.(for example kms_key_name: my-encryption-key)."
478+
description = "Provide the existing kms key name that you want to use for the IBM Spectrum LSF cluster. Note: kms_key_name to be considered only if key_management value is set as key_protect.(for example kms_key_name: my-encryption-key)."
479479
validation {
480480
condition = anytrue([alltrue([var.kms_key_name != null, var.kms_instance_name != null]), (var.kms_key_name == null), (var.key_management != "key_protect")])
481481
error_message = "Please make sure you are passing the kms_instance_name if you are passing kms_key_name."

variables.tf

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1071,7 +1071,7 @@ variable "login_instance" {
10711071
profile = "bx2-2x8"
10721072
image = "hpcaas-lsf10-rhel810-compute-v8"
10731073
}]
1074-
description = "Number of instances to be launched for login node."
1074+
description = "Specify the list of login node configurations, including instance profile, image name. By default, login node is created using Fix Pack 15. If deploying with Fix Pack 14, set lsf_version to fixpack_14 and use the corresponding image hpc-lsf-fp14-compute-rhel810-v1. The selected image must align with the specified lsf_version, any mismatch may lead to deployment failures."
10751075
}
10761076

10771077
##############################################################################
@@ -1101,7 +1101,7 @@ variable "TF_PARALLELISM" {
11011101
##############################################################################
11021102

11031103
variable "sccwp_service_plan" {
1104-
description = "IBM service pricing plan."
1104+
description = "Specify the plan type for the Security and Compliance Center (SCC) Workload Protection instance. Valid values are free-trial and graduated-tier only."
11051105
type = string
11061106
default = "free-trial"
11071107
validation {
@@ -1116,11 +1116,11 @@ variable "sccwp_service_plan" {
11161116
variable "sccwp_enable" {
11171117
type = bool
11181118
default = true
1119-
description = "Flag to enable SCC instance creation. If true, an instance of SCC (Security and Compliance Center) will be created."
1119+
description = "Set this flag to true to create an instance of IBM Security and Compliance Center (SCC) Workload Protection. When enabled, it provides tools to discover and prioritize vulnerabilities, monitor for security threats, and enforce configuration, permission, and compliance policies across the full lifecycle of your workloads. To view the data on the dashboard, enable the cspm to create the app configuration and required trusted profile policies.[Learn more](https://cloud.ibm.com/docs/workload-protection?topic=workload-protection-about)."
11201120
}
11211121

11221122
variable "cspm_enabled" {
1123-
description = "Enable Cloud Security Posture Management (CSPM) for the Workload Protection instance. This will create a trusted profile associated with the SCC Workload Protection instance that has viewer / reader access to the App Config service and viewer access to the Enterprise service. [Learn more](https://cloud.ibm.com/docs/workload-protection?topic=workload-protection-about)."
1123+
description = "CSPM (Cloud Security Posture Management) is a set of tools and practices that continuously monitor and secure cloud infrastructure. When enabled, it creates a trusted profile with viewer access to the App Configuration and Enterprise services for the SCC Workload Protection instance. Make sure the required IAM permissions are in place, as missing permissions will cause deployment to fail. If CSPM is disabled, dashboard data will not be available.[Learn more](https://cloud.ibm.com/docs/workload-protection?topic=workload-protection-about)."
11241124
type = bool
11251125
default = false
11261126
nullable = false

0 commit comments

Comments
 (0)