feat: added ebpf for sysdig agent #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
ocofaigh
reviewed
Jul 10, 2025
| - If not available in the machine already, it tries to build it with the kernel headers | ||
| - if kernel headers not available, it tries to download it | ||
|
|
||
| To fix this, we need the ability to set the helm values `agent.ebpf.enabled` and `agent.ebpf.kind` if cluster is using nodes based on RHCOS by setting the terraform boolean input variable called `enable_universal_ebpf` to true. Enabling universal ebpf needs kernel version to be `5.8` or higher. RHEL8 already has the kernel headers and enabling `ebpf` will not cause any impact even though kernel version is `4.18`. |
There was a problem hiding this comment.
This should be updated to what consumer needs to know. Why and when would a consumer need to change the value of enable_universal_ebpf.
Please give the markdown a title too
There was a problem hiding this comment.
@ocofaigh i changed the doc. Can you please review again and suggest if some other change is needed.
ocofaigh
reviewed
Jul 10, 2025
ocofaigh
reviewed
Jul 10, 2025
ocofaigh
requested changes
Jul 10, 2025
|
|
||
| ### Kernel Compatibility | ||
|
|
||
| - **RHCOS and RHEL9**: Since kernel version **5.14** is used. Default value for variable has been set to true. |
There was a problem hiding this comment.
Should it say 5.14 or later is used?
There was a problem hiding this comment.
As of now 5.14 is used across all ocp versions. But in future versions it can be newer so i will add "or later".
|
/run pipeline |
ocofaigh
previously approved these changes
Jul 10, 2025
|
/run pipeline |
ocofaigh
approved these changes
Jul 10, 2025
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
added ebpf for sysdig agent
Issue
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers