Skip to content

Update eslint-config-airbnb from v16 to v17 #4

Open
@topheman

Description

@topheman

updating eslint-config-airbnb from v16 to v17 outputs the following message

npm WARN [email protected] requires a peer of ajv@^6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of eslint@^4.19.1 || ^5.3.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of eslint-plugin-import@^2.14.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of eslint-plugin-jsx-a11y@^6.1.1 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of eslint-plugin-react@^7.11.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of eslint@^4.19.1 || ^5.3.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of eslint-plugin-import@^2.14.0 but none is installed. You must install peer dependencies yourself.

The reason is that eslint-config-airbnb relies on a bunch of modules that are also installed by react-scripts. In the previous version those modules were in the correct version range.

If we follow the instruction and install peer-dependencies:

npm install --save-dev eslint-config-airbnb@^17.1.0 ajv@^6.0.0 eslint@^5.3.0 eslint-plugin-import@^2.14.0 eslint-plugin-jsx-a11y@^6.1.1 eslint-plugin-react@^7.11.0

We end up with an other warning:

npm WARN [email protected] requires a peer of eslint@^4.1.1 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of eslint-plugin-jsx-a11y@^5.1.1 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of eslint@>=1.6.0 <5.0.0 but none is installed. You must install peer dependencies yourself.

This warning is about react-scripts dependencies which now have trouble with their peer dependencies because the previous install has done some deduplication of modules.

Action to take

  • find out if dedupe can be avoided ?

Infos

npm --version
6.1.0
node --version
v8.9.0

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions