Skip to content

Commit 834ba33

Browse files
committed
KEP 1645: relax the ServiceExportConflict requirements
The KEP states that "a ServiceExportConflict condition will be set on all ServiceExports for the conflicted service", however this assumes an implementation has a central controller that has access to all the constituent ServiceExports or that each cluster has access to the ServiceExports on every other cluster but this may not be the case. This PR modifies the language to recommend the condition be set on all ServiceExports but not require it. See the motivation and further discussion here: kubernetes-sigs/mcs-api#111 (comment) Signed-off-by: Tom Pantelis <[email protected]>
1 parent d551d45 commit 834ba33

File tree

1 file changed

+6
-4
lines changed
  • keps/sig-multicluster/1645-multi-cluster-services-api

1 file changed

+6
-4
lines changed

keps/sig-multicluster/1645-multi-cluster-services-api/README.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1003,10 +1003,12 @@ services. If these properties are out of sync for a subset of exported services,
10031003
there is no clear way to determine how a service should be accessed.
10041004
10051005
Conflict resolution policy: **If any properties have conflicting values that can
1006-
not simply be merged, a `ServiceExportConflict` condition will be set on all
1007-
`ServiceExport`s for the conflicted service with a description of the conflict.
1008-
The conflict will be resolved by assigning precedence based on each
1009-
`ServiceExport`'s `creationTimestamp`, from oldest to newest.**
1006+
not simply be merged, the conflict will be resolved by assigning precedence based on each
1007+
`ServiceExport`'s `creationTimestamp`, from oldest to newest. A `ServiceExportConflict` condition
1008+
will be set on the `ServiceExport`s for the conflicted service with a description of the conflict.
1009+
It is recommended to set the `ServiceExportConflict` condition on all the constituent `ServiceExport`s
1010+
to provide maximum visibility to the user, however, if this is not feasible for an implementation,
1011+
at a minimum it should be set on the constituent `ServiceExport`s that introduced the conflict.**
10101012

10111013
#### Service Port
10121014

0 commit comments

Comments
 (0)