Skip to content

CityJSON objects with no geometry trigger error 906 #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jaspervdv opened this issue Mar 24, 2025 · 2 comments
Open

CityJSON objects with no geometry trigger error 906 #190

jaspervdv opened this issue Mar 24, 2025 · 2 comments

Comments

@jaspervdv
Copy link

When validating a CityJSON file that has a set of objects of which some have no geometry issues arise. I would anticipate the validator to pass over these objects. However the validator returns this as an invalid feature: "Error 906 PRIMITIVE_NO_GEOMETRY Feature has no geometry defined (or val3dity doesn't handle this type). | info=".

The error seems to imply that a primitive is present that has no geometry, but there is no primitive present in this cityjson object.

This is the structure of the object:

"Dachgeschoss": { "attributes": { "IFC Elevation": 2.7, "IFC Guid": [ "273g3wqLzDtfYIl7qqkgcO" ], "IFC Long Name": "ACID00000002-0000-0000-0000-000000000000", "IFC Name": "Dachgeschoss" }, "children": [ "7" ], "parents": [ "Inner Shell" ], "type": "BuildingStorey" }

@hugoledoux
Copy link
Member

That's the behaviour I implemented, val3dity is for validating geometries and if an object has none it could indicate an error... But I agree that it could be annoying for certain.

How would you like to have this case reported? No report: no geom thus no error?

@jaspervdv
Copy link
Author

I personally think it is just the wording "error" that unfortunate, it is not really an error. Would it be possible to mention it just as a warning or info? or is that not a possibility?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants