steampipe query returning exit code 0 when there is an error

[gabrielsoltz]

Describe the bug
Hey Team,
We see that when running steampipe query <file.sql?>, the CLI is returning an error but the exit code is 0.

[ec2-user@stg-dashboards ~]$  $STEAMPIPE_BIN --install-dir $STEAMPIPE_CONFIG query XXXX.sql
Error: relation "XXXX" already exists (SQLSTATE 42P07)
[ec2-user@stg-dashboards ~]$ echo $?
0

Thank you!

Steampipe version (steampipe -v)
Steampipe v1.0.1

To reproduce
Steps to reproduce the behavior (please include relevant code and/or commands).

Expected behavior
A clear and concise description of what you expected to happen.

Additional context
Add any other context about the problem here.

[pskrbasu]

Thank you @gabrielsoltz for raising this issue. We will get it fixed.

[github-actions]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

[github-actions]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

[gabrielsoltz]

@pskrbasu any update on this one?

[pskrbasu]

@gabrielsoltz This is currently planned and is on my list. We will get this sorted soon. Thanks!

[frek818]

@pskrbasu , will this handle return non-zero on errors in general?

I know that the check sub-command has been deprecated and removed. However, I expect steampipe check ... (or any non-existant sub-command) to return a non-zero exit code.

Should I open a separate issue for this?

[pskrbasu]

@frek818 All Steampipe commands return non-zero exit codes in the event of errors. This issue is a specific bug in steampipe query where the relation already exists returns a 0 exit code.
If you find any existing Steampipe commands which don't return a non-zero exit code in case of failures, you should report to us and create an issue.

[frek818]

Apology for piggybacking on this issue. I created a new issue #4563 for the bug that I'm experiencing. I've also took a stab at a pull request (#4564) to fix it.