make Combobox optionTemplate prop generic

[vankhoawin]

paste/packages/paste-core/components/combobox/src/types.ts

Line 22 in 91903a6

optionTemplate?: (item: string | {}) => React.ReactNode;

Currently, optionTemplate is a function with a string | {} input. We can provide stronger and more accurate typing by making ComboboxProps and furthermore Combobox generic.

some examples how to do so in StackOverflow: https://stackoverflow.com/a/58473012

[TheSisb]

Hi @vnguyen94, good suggestion! Did you encounter a specific issue with the typing or is this more of an observation where we can make an enhancement?

Always open to PRs too <3

[vankhoawin]

I guess, both? 😄 we ran into it when trying to type item as SomeInterface/Type, and it wouldn't let us without using @ts-ignore to bypass that.

It's tweek so just wanted to leave a placeholder before I forgot, maybe I can circle back on a PR afterwards

[corinne-nagel]

Hey, @vnguyen94 I'm closing out discussions that have been finished/answered. Did you get a chance to PR this? 🙂

[vankhoawin]

i did not 😓 kinda getting busy lately, but the issue still exists. a look at antd has a workaround for typing React.forwardRef components: https://github.com/ant-design/ant-design/blob/82b49c83139f481f127fe649e28ff2138a34063e/components/select/index.tsx#L147-L159

[corinne-nagel]

No worries, I'll add a ticket for this. Thanks for sharing!