Skip to content

Commit 9e06108

Browse files
chore: handle model parameters, support patch operation, skip getter override (#649)
1 parent d0d7a99 commit 9e06108

File tree

4 files changed

+11
-6
lines changed

4 files changed

+11
-6
lines changed

examples/java/src/main/java/com/twilio/rest/previewiam/organizations/User.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,9 +93,6 @@ static public class ScimName {
9393
@JsonInclude(JsonInclude.Include.NON_EMPTY)
9494
@JsonProperty("TestAnyType")
9595
@Getter @Setter private Object testAnyType;
96-
public String getTestAnyType() {
97-
return Converter.objectToJson(testAnyType);
98-
}
9996

10097
public static ScimName fromJson(String jsonString, ObjectMapper mapper) throws IOException {
10198
return mapper.readValue(jsonString, ScimName.class);

src/main/java/com/twilio/oai/api/JavaApiResourceBuilder.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,7 @@ public ApiResourceBuilder updateOperations(Resolver<CodegenParameter> codegenPar
137137
// currently supporting required and conditional parameters only for request body object
138138
if (model != null) {
139139
model.vendorExtensions.put("x-constructor-required", true);
140+
model.vendorExtensions.put("x-model-parameters", generateSignatureListBody(co));
140141
jsonRequestBodyResolver.resolve(item, codegenParameterIResolver);
141142
}
142143
});
@@ -214,10 +215,12 @@ public void updateHttpMethod(CodegenOperation co) {
214215
case "PUT":
215216
co.vendorExtensions.put(HTTP_METHOD, JavaHttpMethod.PUT.getValue());
216217
break;
218+
case "PATCH":
219+
co.vendorExtensions.put(HTTP_METHOD, JavaHttpMethod.PATCH.getValue());
220+
break;
217221
case "DELETE":
218222
co.vendorExtensions.put(HTTP_METHOD, JavaHttpMethod.DELETE.getValue());
219223
break;
220-
221224
}
222225
}
223226

src/main/java/com/twilio/oai/common/EnumConstants.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,7 @@ public enum JavaHttpMethod {
114114
GET("HttpMethod.GET"),
115115
POST("HttpMethod.POST"),
116116
PUT("HttpMethod.PUT"),
117+
PATCH("HttpMethod.PATCH"),
117118
DELETE("HttpMethod.DELETE"),
118119
HEAD("HttpMethod.HEAD"),
119120
OPTIONS("HttpMethod.OPTIONS");

src/main/resources/twilio-java/models.mustache

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,20 +12,24 @@
1212
@Getter @Setter private {{{dataType}}} {{name}};
1313
{{/vendorExtensions.x-ref-enum}}
1414
{{^isMap}}
15+
{{^isFreeFormObject}}
16+
{{^isAnyType}}
1517
{{#vendorExtensions.x-serialize}}
1618
public String get{{#lambda.titlecase}}{{name}}{{/lambda.titlecase}}() {
1719
return {{vendorExtensions.x-serialize}};
1820
}{{/vendorExtensions.x-serialize}}
21+
{{/isAnyType}}
22+
{{/isFreeFormObject}}
1923
{{/isMap}}
2024
{{/vars}}
2125
{{#vendorExtensions.x-constructor-required}}
22-
{{#modelParameters}}
26+
{{#vendorExtensions.x-model-parameters}}
2327
public {{classname}}({{#.}}final {{{dataType}}} {{name}}{{^-last}}, {{/-last}}{{/.}} ) {
2428
{{#.}}
2529
this.{{name}} = {{name}};
2630
{{/.}}
2731
}
28-
{{/modelParameters}}
32+
{{/vendorExtensions.x-model-parameters}}
2933
{{/vendorExtensions.x-constructor-required}}
3034

3135
{{^vendorExtensions.x-response}}

0 commit comments

Comments
 (0)