Skip to content

Commit 3b93d8c

Browse files
author
Warren Buckley
authored
Merge pull request #27 from umbraco-community/bugfix/multi-target-net6-net5
Bugfix MultiTarget .NET6 & .NET 5
2 parents e45baf9 + 567b53b commit 3b93d8c

File tree

6 files changed

+31
-16
lines changed

6 files changed

+31
-16
lines changed

.github/workflows/codeql-analysis.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,15 @@ jobs:
4343
with:
4444
fetch-depth: 0
4545

46+
- name: Setup .NET
47+
uses: actions/setup-dotnet@v1
48+
with:
49+
dotnet-version: '5.0.x'
50+
4651
- name: Setup .NET
4752
uses: actions/setup-dotnet@v1
4853
with:
4954
dotnet-version: '6.0.x'
50-
include-prerelease: true
5155

5256
# Initializes the CodeQL tools for scanning.
5357
- name: Initialize CodeQL

.github/workflows/dotnet.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,15 @@ jobs:
2121
with:
2222
fetch-depth: 0
2323

24+
- name: Setup .NET
25+
uses: actions/setup-dotnet@v1
26+
with:
27+
dotnet-version: '5.0.x'
28+
2429
- name: Setup .NET
2530
uses: actions/setup-dotnet@v1
2631
with:
2732
dotnet-version: '6.0.x'
28-
include-prerelease: true
2933

3034
- name: Restore dependencies
3135
run: dotnet restore

.github/workflows/release-nuget.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,15 @@ jobs:
2121
with:
2222
fetch-depth: 0
2323

24+
- name: Setup .NET
25+
uses: actions/setup-dotnet@v1
26+
with:
27+
dotnet-version: '5.0.x'
28+
2429
- name: Setup .NET
2530
uses: actions/setup-dotnet@v1
2631
with:
2732
dotnet-version: '6.0.x'
28-
include-prerelease: true
2933

3034
- name: Restore dependencies
3135
run: dotnet restore

Our.Umbraco.TagHelpers.Playground/Our.Umbraco.TagHelpers.Playground.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
<Project Sdk="Microsoft.NET.Sdk.Web">
22

33
<PropertyGroup>
4-
<TargetFramework>net6.0</TargetFramework>
4+
<TargetFramework>net5.0</TargetFramework>
55
<DefaultItemExcludes>$(DefaultItemExcludes);App_Plugins/**;</DefaultItemExcludes>
66
<DefaultItemExcludes>$(DefaultItemExcludes);umbraco/**;</DefaultItemExcludes>
77
<DefaultItemExcludes>$(DefaultItemExcludes);wwwroot/media/**;</DefaultItemExcludes>
88
</PropertyGroup>
99

1010
<ItemGroup>
11-
<PackageReference Include="Umbraco.Cms" Version="9.0.1" />
11+
<PackageReference Include="Umbraco.Cms" Version="9.1.0" />
1212
</ItemGroup>
1313

1414

Our.Umbraco.TagHelpers.Tests/Our.Umbraco.TagHelpers.Tests.csproj

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,21 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFramework>net6.0</TargetFramework>
4+
<TargetFramework>net5.0</TargetFramework>
55

66
<IsPackable>false</IsPackable>
77
</PropertyGroup>
88

99
<ItemGroup>
1010
<PackageReference Include="Microsoft.AspNetCore.Mvc.ViewFeatures" Version="2.2.0" />
1111
<PackageReference Include="Microsoft.AspNetCore.Razor" Version="2.2.0" />
12-
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.9.4" />
13-
<PackageReference Include="NUnit" Version="3.13.1" />
14-
<PackageReference Include="NUnit3TestAdapter" Version="3.17.0" />
15-
<PackageReference Include="coverlet.collector" Version="3.0.2" />
12+
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.0.0" />
13+
<PackageReference Include="NUnit" Version="3.13.2" />
14+
<PackageReference Include="NUnit3TestAdapter" Version="4.1.0" />
15+
<PackageReference Include="coverlet.collector" Version="3.1.0">
16+
<PrivateAssets>all</PrivateAssets>
17+
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
18+
</PackageReference>
1619
</ItemGroup>
1720

1821
<ItemGroup>

Our.Umbraco.TagHelpers/Our.Umbraco.TagHelpers.csproj

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFramework>net6.0</TargetFramework>
4+
<TargetFrameworks>net5.0;net6.0</TargetFrameworks>
55
</PropertyGroup>
66

77
<PropertyGroup>
@@ -32,15 +32,15 @@
3232
</PropertyGroup>
3333

3434
<ItemGroup>
35-
<PackageReference Include="Microsoft.AspNetCore.DataProtection.Abstractions" Version="5.0.11" />
35+
<PackageReference Include="Microsoft.AspNetCore.DataProtection.Abstractions" Version="6.0.0" />
3636
<PackageReference Include="Microsoft.AspNetCore.Mvc.ViewFeatures" Version="2.2.0" />
3737
<PackageReference Include="Microsoft.AspNetCore.Razor" Version="2.2.0" />
3838
<PackageReference Include="Stubble.Core" Version="1.9.3" />
39-
<PackageReference Include="Umbraco.Cms.Core" Version="9.0.1" />
40-
<PackageReference Include="Umbraco.Cms.Web.Common" Version="9.0.1" />
39+
<PackageReference Include="Umbraco.Cms.Core" Version="9.1.0" />
40+
<PackageReference Include="Umbraco.Cms.Web.Common" Version="9.1.0" />
4141

42-
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="All" />
43-
<PackageReference Include="GitVersion.MsBuild" Version="5.6.10*" PrivateAssets="All" />
42+
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="All" />
43+
<PackageReference Include="GitVersion.MsBuild" Version="5.8.1" PrivateAssets="All" />
4444
</ItemGroup>
4545

4646
<ItemGroup>

0 commit comments

Comments
 (0)