More complex Validation options

[matt-tolliday-iss]

Would it possible to consider enabling more complex validation options other than a Regex on a field, as is currently available.

My specific scenario is to ensure a uniqueness of the entity being saved on two particular fields within the database table.

When trying to create a new entity which violates the constraint, Konstukt returns a green successful message to the UI, but throws an exception, and the entity is not added/created (which is expected)

System.NullReferenceException: 'Object reference not set to an instance of an object.'

This exception was originally thrown at this call stack:
    Konstrukt.Web.Controllers.Trees.KonstruktTreeController.GetTreeNode(string, Microsoft.AspNetCore.Http.FormCollection)
    Microsoft.AspNetCore.Mvc.Infrastructure.ActionMethodExecutor.SyncObjectResultExecutor.Execute(Microsoft.AspNetCore.Mvc.Infrastructure.IActionResultTypeMapper, Microsoft.Extensions.Internal.ObjectMethodExecutor, object, object[]) in ActionMethodExecutor.cs
    Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.InvokeActionMethodAsync.__Logged|12_1(Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker)
    System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() in ExceptionDispatchInfo.cs

[mattbrailsford]

Hey @matt-tolliday-iss we do support validation data annotiations on the POCO model so you could in theory create a custom data annotation to validate the uniquness and Konstrukt should then fail it's model validation.

I'm sure there could be something we could do though to add support for custom validators as part of the fluent configuration.

This said, it sounds like there is a bug here too as the UI shouldn't give a success message if there is a SQL error when asked to save.

[matt-tolliday-iss]

@mattbrailsford thanks, that's good to know that data annotations are supported - I am having an issue with using the DI ServiceProvider within a custom ValidationAttribute to grab the repo and perform some uniqueness checks against the dataset - it seems that the ServiceProvider is not initialised from where the validation is called from within the Konstrukt controller, the provider returns null when the attribute is added to a property, and the ServiceProvider itself is null when added to the class.

Specifically from > Konstrukt.Web.dll!Konstrukt.Web.WebApi.Validation.KonstruktEntityValidator.ValidateDataAnnotations(Microsoft.AspNetCore.Mvc.ModelBinding.ModelStateDictionary modelState, object entity) Unknown

I don't suppose you have any ideas on this one?

TIA

[mattbrailsford]

Oops, looks like I forgot to pass it through. I've added it now and there will be a new beta build on the unstable feed shortly 👍

[matt-tolliday-iss]

@mattbrailsford one more! sorry! - it looks like its not honouring the "false" return value of the IsValid overload with ValidationContext - I can see that despite the latter return value in the screenshot below, its still attempting to do the insert/create in the Umbraco logs, which fails due to the database constraint.

[mattbrailsford]

No problem. I’ll take a look to see what’s going on but it’ll be Monday now. Have a great weekend and thanks for all the feedback 👍🏻

[mattbrailsford]

This should be resolved now and on the unstable feed shortly.

Our code assumed that failed validation results should pass the member names back (you can copy the members names from the context to the validation result) and so because only a validation failure message was passed it didn't register the validation error.

I've updated it now such that if you pass the member names back they appear as property validation messages, but if you don't pass a member name, it's assumed it's an object level validation issue and so just shows the validation error without highligting a property at fault.