Skip to content

Consider updating to Quill 2.0 once stable is released #1680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
web-padawan opened this issue May 17, 2019 · 5 comments · May be fixed by #9007
Open

Consider updating to Quill 2.0 once stable is released #1680

web-padawan opened this issue May 17, 2019 · 5 comments · May be fixed by #9007
Labels
enhancement New feature or request vaadin-rich-text-editor

Comments

@web-padawan
Copy link
Member

Quickly updated RTE on top of Quill 2.0.0-dev.3 for possible using in Incubator project.

Prototype branch: https://github.com/vaadin/vaadin-rich-text-editor/tree/quill-2x
Quill fork: https://github.com/web-padawan/quill/tree/shadow-2x

There are at least 2 breaking changes in Quill 2.0 affecting us:

  • <div class="ql-code-editor-container"> is now used for code blocks instead of <pre>
  • <ol> is now used for all lists, and type is set via <li data-list="bullet>">

Also, few keyboard navigation tests failed (didn't spend any time to investigate).

Once 2.0 is released as a stable we should keep this in mind if we want to update.
@vaadin-bot vaadin-bot transferred this issue from vaadin/vaadin-rich-text-editor May 19, 2021
@web-padawan
Copy link
Member Author

Regarding <ol> tag used for list - here's a comment suggesting quill.getSemanticHTML() which returns correct markup.

@web-padawan
Copy link
Member Author

One issue which might be fixed by upgrading to Quill 2: vaadin/flow-components#4773

@web-padawan
Copy link
Member Author

Some commits in v2.0 with improvements that we could benefit from:

We could also investigate supporting nested lists feature as quill.getSemanticHTML() correctly returns markup also for nested lists as described in the issue: slab/quill#979 (comment). Note that indentation outside lists (i.e. in regular paragraphs) would still need to be handled by replacing ql-indent classes, see slab/quill#4156

@StefanPenndorf
Copy link

Is there a timeline for upgrading to Quill 2? The 1st birthday of Quill 2.0 is just 2 month away ;-). Latest Version is 2.0.3 from November 2024 thus Quill 2 seems to be pretty stable. According to previous comments quill2 might also solve some issues.

https://github.com/slab/quill/releases/tag/v2.0.3
https://www.npmjs.com/package/quill2

@TatuLund
Copy link
Contributor

Enhanced RTE add-on has Quill v2 in the latest version as we added support for tables using the 3rd party table plugin.

https://vaadin.com/directory/component/enhanced-rich-text-editor

@web-padawan web-padawan linked a pull request Apr 25, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request vaadin-rich-text-editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor!: update to Quill v2, drop outdated Firefox patch vaadin/web-components
4 participants
@StefanPenndorf @web-padawan @TatuLund @vaadin-bot