From e5146c1785c7e63c7b41107ab5adadf386988ba6 Mon Sep 17 00:00:00 2001
From: Mattes Mohr <mail@mattesmohr.de>
Date: Sat, 12 Jul 2025 10:23:35 +0200
Subject: [PATCH] Make the selected attribute conditional

---
 .../Attributes/BasicAttributes.swift          | 20 ++++++++++++++-----
 .../Abstraction/Elements/InputElements.swift  |  9 +++++++--
 Tests/HTMLKitTests/AttributesTests.swift      | 16 +++++++++++++--
 3 files changed, 36 insertions(+), 9 deletions(-)

diff --git a/Sources/HTMLKit/Abstraction/Attributes/BasicAttributes.swift b/Sources/HTMLKit/Abstraction/Attributes/BasicAttributes.swift
index a510e27e..24e36d00 100644
--- a/Sources/HTMLKit/Abstraction/Attributes/BasicAttributes.swift
+++ b/Sources/HTMLKit/Abstraction/Attributes/BasicAttributes.swift
@@ -3065,16 +3065,26 @@ extension PropertyAttribute where Self: EmptyNode {
     }
 }
 
-/// The protocol provides the element with the selected handler.
+/// A type that provides the `selected` modifier
 @_documentation(visibility: internal)
 public protocol SelectedAttribute: Attribute {
     
-    /// The function represents the html-attribute 'selected'.
+    /// Mark a select option as default.
     ///
-    /// ```html
-    /// <tag selected />
+    /// ```swift
+    /// Select {
+    ///     Option()
+    ///         .value("lorem")
+    ///         .selected()
+    /// }
+    /// .name("lorem")
+    /// .id("lorem")
     /// ```
-    func selected() -> Self
+    ///
+    /// - Parameter condition: Whether to default the option.
+    ///
+    /// - Returns: The element
+    func selected(_ condition: Bool) -> Self
 }
 
 extension SelectedAttribute where Self: ContentNode {
diff --git a/Sources/HTMLKit/Abstraction/Elements/InputElements.swift b/Sources/HTMLKit/Abstraction/Elements/InputElements.swift
index 965f7a0e..77a2bc99 100644
--- a/Sources/HTMLKit/Abstraction/Elements/InputElements.swift
+++ b/Sources/HTMLKit/Abstraction/Elements/InputElements.swift
@@ -528,8 +528,13 @@ extension Option: GlobalAttributes, GlobalEventAttributes, GlobalAriaAttributes,
         return mutate(value: value)
     }
     
-    public func selected() -> Option {
-        return mutate(selected: "selected")
+    public func selected(_ condition: Bool = true) -> Option {
+        
+        if condition {
+            return mutate(selected: "selected")
+        }
+        
+        return self
     }
     
     public func popover(_ value: Values.Popover.State) -> Option {
diff --git a/Tests/HTMLKitTests/AttributesTests.swift b/Tests/HTMLKitTests/AttributesTests.swift
index 2e15b11f..7132af15 100644
--- a/Tests/HTMLKitTests/AttributesTests.swift
+++ b/Tests/HTMLKitTests/AttributesTests.swift
@@ -573,8 +573,13 @@ final class AttributesTests: XCTestCase {
             return self.mutate(property: value.rawValue)
         }
         
-        func selected() -> Tag {
-            return self.mutate(selected: "selected")
+        func selected(_ condition: Bool = true) -> Tag {
+            
+            if condition {
+                return self.mutate(selected: "selected")
+            }
+            
+            return self
         }
         
         func draw(_ value: String) -> Tag {
@@ -2119,11 +2124,18 @@ final class AttributesTests: XCTestCase {
     func testSelectedAttribute() throws {
         
         let view = TestView {
+            // unconditionally
             Tag {}.selected()
+            // with a false condition
+            Tag {}.selected(false)
+            // with a true condition
+            Tag {}.selected(true)
         }
         
         XCTAssertEqual(try renderer.render(view: view),
                        """
+                       <tag selected="selected"></tag>\
+                       <tag></tag>\
                        <tag selected="selected"></tag>
                        """
         )