remove large files streaming and update main changelog

Author: vbilopav

NpgsqlRestClient/AppStaticFileMiddleware.cs

@@ -25,9 +25,6 @@ public class AppStaticFileMiddleware
 
     private static readonly ConcurrentDictionary<string, bool> _pathInParsePattern = new();
 
-    const long StreamingThreshold = 1024 * 1024 * 10; // 10MB
-    const int MaxBufferSize = 8192; // 8KB
-
     public static void ConfigureStaticFileMiddleware(
         bool parse,
         string[]? parsePatterns,
@@ -143,69 +140,38 @@ public async Task InvokeAsync(HttpContext context)
                     customClaims: _customClaimTags,
                     customParameters: null);
 
-
-                if (fileInfo.Length < StreamingThreshold)
-                {
-                    byte[] buffer = new byte[(int)fileInfo.Length];
-                    await fileStream.ReadExactlyAsync(buffer, context.RequestAborted);
-                    int charCount = Encoding.UTF8.GetCharCount(buffer);
-                    char[] chars = ArrayPool<char>.Shared.Rent(charCount);
-                    try
-                    {
-                        Encoding.UTF8.GetChars(buffer, 0, buffer.Length, chars, 0);
-                        ReadOnlySpan<char> result = parser.Parse(new ReadOnlySpan<char>(chars, 0, charCount), context);
-                        var writer = PipeWriter.Create(context.Response.Body);
-                        try
-                        {
-                            int maxBytesNeeded = Encoding.UTF8.GetMaxByteCount(result.Length);
-                            Memory<byte> memory = writer.GetMemory(maxBytesNeeded);
-                            int actualBytesWritten = Encoding.UTF8.GetBytes(result, memory.Span);
-                            writer.Advance(actualBytesWritten);
-                            context.Response.ContentLength = actualBytesWritten;
-                            await writer.FlushAsync(context.RequestAborted);
-                        }
-                        finally
-                        {
-                            await writer.CompleteAsync();
-                        }
-                    }
-                    finally
-                    {
-                        ArrayPool<char>.Shared.Return(chars);
-                    }
-                }
-                else
+                byte[] buffer = new byte[(int)fileInfo.Length];
+                await fileStream.ReadExactlyAsync(buffer, context.RequestAborted);
+                int charCount = Encoding.UTF8.GetCharCount(buffer);
+                char[] chars = ArrayPool<char>.Shared.Rent(charCount);
+                try
                 {
+                    Encoding.UTF8.GetChars(buffer, 0, buffer.Length, chars, 0);
+                    ReadOnlySpan<char> result = parser.Parse(new ReadOnlySpan<char>(chars, 0, charCount), context);
                     var writer = PipeWriter.Create(context.Response.Body);
                     try
                     {
-                        using var reader = new StreamReader(fileStream, Encoding.UTF8, leaveOpen: true);
-                        char[] chars = ArrayPool<char>.Shared.Rent(MaxBufferSize);
-                        try
-                        {
-                            int charsRead;
-                            while ((charsRead = await reader.ReadAsync(chars, context.RequestAborted)) > 0)
-                            {
-                                var result = parser.Parse(chars.AsSpan(0, charsRead), context);
-                                int bytesWritten = Encoding.UTF8.GetBytes(result, writer.GetSpan(result.Length));
-                                writer.Advance(bytesWritten);
-                                await writer.FlushAsync(context.RequestAborted);
-                            }
-                        }
-                        finally
-                        {
-                            ArrayPool<char>.Shared.Return(chars);
-                        }
+                        int maxBytesNeeded = Encoding.UTF8.GetMaxByteCount(result.Length);
+                        Memory<byte> memory = writer.GetMemory(maxBytesNeeded);
+                        int actualBytesWritten = Encoding.UTF8.GetBytes(result, memory.Span);
+                        writer.Advance(actualBytesWritten);
+                        context.Response.ContentLength = actualBytesWritten;
+                        await writer.FlushAsync(context.RequestAborted);
                     }
                     finally
                     {
                         await writer.CompleteAsync();
                     }
                 }
+                finally
+                {
+                    ArrayPool<char>.Shared.Return(chars);
+                }
             }
             catch (IOException ex)
             {
                 _logger?.Error(ex, "Failed to serve static file {Path}", path.ToString());
+
                 context.Response.Clear();
                 await _next(context);
                 return;

changelog.md

@@ -4,6 +4,41 @@ Note: For a changelog for a client application [see the client application page
 
 ---
 
+## Version [2.22.0](https://github.com/vb-consulting/NpgsqlRest/tree/2.22.0 (2025-04-07)
+
+[Full Changelog](https://github.com/vb-consulting/NpgsqlRest/compare/2.22.0...2.21.0)
+
+## Improved Logging
+
+Improved Logging for Endpoint creation to include routine and endpoint:
+
+```console
+[14:56:17.477 INF] Function auth.login mapped to POST /api/auth/login has set ALLOW ANONYMOUS by the comment annotation. [NpgsqlRest]
+```
+
+## Fixed CRUD Plugin
+
+CRUD Endpoints are finally getting some love: 
+- Fixed issue with connection as data source.
+- Added new tags: `onconflict`, `on_conflict` and `on-conflict` to generated endpoints handling with on conflict resoluions.
+
+Now it's possible to enable or disable those endpoints explicitly with comment annotations:
+
+```sql
+create table test.crud_table (
+    id bigint generated always as identity primary key,
+    name text not null,
+    description text,
+    created_at timestamp default now()
+);
+
+comment on table test.crud_table is '
+HTTP
+for on-conflict 
+disabled
+';
+```
+
 ## Version [2.21.0](https://github.com/vb-consulting/NpgsqlRest/tree/2.21.0 (2025-03-24)
 
 [Full Changelog](https://github.com/vb-consulting/NpgsqlRest/compare/2.21.0...2.20.0)

client.md

@@ -91,9 +91,12 @@ Example: override Auth:CookieName config npgsqlrest --auth:cookiename=Test
 
 ## Changelog
 
-## 2.16.0
+## 2.17.0
+
 
 
+## 2.16.0
+
 ### New option `ConnectionSettings.LogConnectionNoticeEventsMode`
 
 ```json