Improve error handling for environment variable parsing

This commit addresses code review feedback to improve robustness:

1. Add proper error handling for strconv.ParseBool in validateKVEventConfiguration()
   - Return descriptive errors instead of silently ignoring parse failures
   - Help users identify configuration issues early

2. Add warning logs in validateConfiguration() for invalid boolean values
   - Log warnings when environment variables contain invalid boolean values
   - Default to false but inform users about the parsing issue

3. Replace goto with labeled break for better Go idioms
   - Use labeled break instead of goto for loop exit
   - Improves code readability and follows Go best practices

These changes make configuration errors more visible and easier to debug,
preventing silent failures when users set invalid environment variable values.

Signed-off-by: ZHENYU <[email protected]>

Author: ae86zhizhi

pkg/cache/kv_event_manager_zmq.go

@@ -43,7 +43,10 @@ func NewKVEventManager(store *Store) *KVEventManager {
 func validateKVEventConfiguration() error {
 	// Check if KV sync is enabled
 	kvSyncValue := utils.LoadEnv(constants.EnvKVEventSyncEnabled, "false")
-	kvSyncRequested, _ := strconv.ParseBool(kvSyncValue)
+	kvSyncRequested, err := strconv.ParseBool(kvSyncValue)
+	if err != nil {
+		return fmt.Errorf("invalid boolean value for %s: %q", constants.EnvKVEventSyncEnabled, kvSyncValue)
+	}
 
 	if !kvSyncRequested {
 		// Not an error - just disabled
@@ -52,7 +55,10 @@ func validateKVEventConfiguration() error {
 
 	// If enabled, check requirements
 	remoteTokenValue := utils.LoadEnv("AIBRIX_USE_REMOTE_TOKENIZER", "false")
-	remoteTokenizerEnabled, _ := strconv.ParseBool(remoteTokenValue)
+	remoteTokenizerEnabled, err := strconv.ParseBool(remoteTokenValue)
+	if err != nil {
+		return fmt.Errorf("invalid boolean value for AIBRIX_USE_REMOTE_TOKENIZER: %q", remoteTokenValue)
+	}
 
 	if !remoteTokenizerEnabled {
 		return fmt.Errorf("KV event sync requires remote tokenizer (set AIBRIX_USE_REMOTE_TOKENIZER=true)")

pkg/kvevent/manager.go

@@ -85,6 +85,7 @@ func (m *Manager) Start() error {
 	ticker := time.NewTicker(1 * time.Second)
 	defer ticker.Stop()
 
+IndexerReadyLoop:
 	for {
 		select {
 		case <-initCtx.Done():
@@ -99,12 +100,10 @@ func (m *Manager) Start() error {
 				return fmt.Errorf("failed to get sync indexer: %w", err)
 			}
 			// Success - indexer is ready
-			goto indexerReady
+			break IndexerReadyLoop
 		}
 	}
 
-indexerReady:
-
 	// Process existing pods
 	err := m.podProvider.RangePods(initCtx, func(key string, podInfo *PodInfo) bool {
 		if m.shouldSubscribe(podInfo) {
@@ -301,11 +300,19 @@ func (m *Manager) unsubscribeFromPod(podKey string) {
 func validateConfiguration() bool {
 	// Check if KV sync is enabled
 	kvSyncValue := utils.LoadEnv(constants.EnvKVEventSyncEnabled, "false")
-	kvSyncRequested, _ := strconv.ParseBool(kvSyncValue)
+	kvSyncRequested, err := strconv.ParseBool(kvSyncValue)
+	if err != nil {
+		klog.Warningf("Invalid boolean value for %s: %q. Defaulting to false.", constants.EnvKVEventSyncEnabled, kvSyncValue)
+		kvSyncRequested = false
+	}
 
 	// Check remote tokenizer
 	remoteTokenValue := utils.LoadEnv("AIBRIX_USE_REMOTE_TOKENIZER", "false")
-	remoteTokenizerEnabled, _ := strconv.ParseBool(remoteTokenValue)
+	remoteTokenizerEnabled, err := strconv.ParseBool(remoteTokenValue)
+	if err != nil {
+		klog.Warningf("Invalid boolean value for AIBRIX_USE_REMOTE_TOKENIZER: %q. Defaulting to false.", remoteTokenValue)
+		remoteTokenizerEnabled = false
+	}
 
 	if kvSyncRequested && !remoteTokenizerEnabled {
 		klog.Warning("KV event sync requires remote tokenizer. Disabling.")