Skip to content

Commit 90eabb2

Browse files
okdshinaarnphm
andcommitted
Apply suggestions from code review
Co-authored-by: Aaron Pham <[email protected]> Signed-off-by: okada shintarou <[email protected]>
1 parent 0a0920a commit 90eabb2

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

vllm/entrypoints/openai/cli_args.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,8 @@ def make_arg_parser(parser: FlexibleArgumentParser) -> FlexibleArgumentParser:
227227
"--expand-tools-even-if-tool-choice-none",
228228
action="store_true",
229229
default=False,
230-
help="[DEPRECATED] Include tool definitions in prompts "
230+
deprecated=True,
231+
help="Include tool definitions in prompts "
231232
"even when tool_choice='none'. "
232233
"This is a transitional option that will be removed in v0.10.0. "
233234
"In v0.10.0, tool definitions will always be included regardless of "

vllm/entrypoints/openai/serving_chat.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ async def create_chat_completion(
181181
and not self.expand_tools_even_if_tool_choice_none):
182182
assert request.tools is not None
183183
if len(request.tools) > 0:
184-
logger.warning(
184+
logger.warning_once(
185185
"Tools are specified but tool_choice is set to 'none' "
186186
"and --expand-tools-even-if-tool-choice-none is not "
187187
"enabled. Tool definitions will be excluded from the "

0 commit comments

Comments
 (0)