bump redis to latest v9 and ratelimit to v10 #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilien1010
force-pushed
the
fix-redis-xinfo-param
branch
4 times, most recently
from
b003fda to
4de783f
Compare
There was a problem hiding this comment.
Pull Request Overview
This pull request updates dependency versions for Redis and Redis rate limiting, aligning the code with the new go-redis v9 and redis_rate v10 APIs. Key changes include:
- Switching import paths from go-redis/redis/v8 to redis/go-redis/v9.
- Updating redis_rate from v9 to v10 in multiple files.
- Adjusting method names and signatures to match the updated APIs (e.g. XTrim to XTrimMaxLen and changes from pointer to value for redis.Z).
Reviewed Changes
Copilot reviewed 13 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| taskq.go | Updated Redis client import and extended the Redis interface with new methods. |
| redisq/queue.go | Updated method names/signatures (e.g., XTrim -> XTrimMaxLen, ZAdd parameter change). |
| queue.go | Bumped redis_rate dependency to v10. |
| example_test.go | Updated redis_rate dependency version. |
| example/sqsexample/tasks.go | Updated Redis client import. |
| example/redisexample/tasks.go | Updated Redis client import. |
| consumer_test.go | Revised imports and grouped constant declarations. |
| consumer.go | Updated redis_rate dependency. |
| .github/workflows/build.yml | Expanded supported Go version matrix to include newer versions. |
Files not reviewed (4)
- example/redisexample/go.mod: Language not supported
- example/sqsexample/go.mod: Language not supported
- extra/taskqotel/go.mod: Language not supported
- go.mod: Language not supported
Comments suppressed due to low confidence (2)
redisq/queue.go:264
- Ensure that the renamed method 'XTrimMaxLen' accurately replicates the behavior of the previous 'XTrim', so that stream trimming behaves as expected with the updated Redis client API.
_ = q.redis.XTrimMaxLen(ctx, q.stream, 0).Err()
redisq/queue.go:173
- Verify that changing the ZAdd parameter from a pointer to a value (from &redis.Z to redis.Z) is consistent with the updated go-redis v9 API and does not introduce side effects in error handling or value comparisons.
return pipe.ZAdd(msg.Ctx, q.zset, redis.Z{
|
Seems always the test case TestRedisqAckMessage is a little bit noise @vmihailenco |
lilien1010
force-pushed
the
fix-redis-xinfo-param
branch
2 times, most recently
from
12b29f3 to
23b5110
Compare
lilien1010
force-pushed
the
fix-redis-xinfo-param
branch
from
23b5110 to
6b6fc37
Compare
|
CC @rymurr Seems the test |
|
@lilien1010 : It looks like I can not use Because, as I checked, the taskq.Redis interface depends directly on go-redis/v8 This is not a good design IMHO, cc @vmihailenco also |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #203
close #200
Bump github.com/bsm/redislock
Bump github.com/go-redis/redis_rate/v10 v10.0.1
Bump github.com/redis/go-redis/v9 v9.8.0
Also fix when connect to redis 7.x
taskq: 2025/05/01 16:29:01 queue.go:305: redisq: clean_zombie_consumers failed: redis: got 8 elements in XINFO CONSUMERS reply, wanted 6