Skip to content

Commit 043c64c

Browse files
authored
Merge pull request #1672 from volatilityfoundation/refactor/symbol_server_url_constant
Pdbconv: Make symbol server URL constant
2 parents 9b0ca19 + 134a3bc commit 043c64c

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

volatility3/framework/constants/__init__.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@
4040
ISF_EXTENSIONS = [".json", ".json.xz", ".json.gz", ".json.bz2"]
4141
"""List of accepted extensions for ISF files"""
4242

43+
SYMBOL_SERVER_URL = "http://msdl.microsoft.com/download/symbols"
44+
4345
if hasattr(sys, "frozen") and sys.frozen:
4446
# Ensure we include the executable's directory as the base for plugins and symbols
4547
PLUGINS_PATH = [

volatility3/framework/symbols/windows/pdbconv.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -950,7 +950,7 @@ def retreive_pdb(
950950
) -> Optional[str]:
951951
vollog.info("Download PDB file...")
952952
file_name = ".".join(file_name.split(".")[:-1] + ["pdb"])
953-
for sym_url in ["http://msdl.microsoft.com/download/symbols"]:
953+
for sym_url in [constants.SYMBOL_SERVER_URL]:
954954
url = sym_url + f"/{file_name}/{guid}/"
955955

956956
result = None

0 commit comments

Comments
 (0)