Skip to content

Commit e613291

Browse files
authored
Merge pull request #191 from bastelfreak/bug
handle stringified facterversion properly
2 parents 84730e6 + edb710b commit e613291

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

lib/rspec-puppet-facts.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,9 +116,10 @@ def on_supported_os_implementation(opts = {})
116116
# FacterDB may have newer versions of facter data for which it contains a subset of all possible
117117
# facter data (see FacterDB 0.5.2 for Facter releases 3.8 and 3.9). In this situation we need to
118118
# cycle through and downgrade Facter versions per platform type until we find matching Facter data.
119+
facterversion_key = RSpec.configuration.facterdb_string_keys ? 'facterversion' : :facterversion
119120
filter.each do |filter_spec|
120121
versions = FacterDB.get_facts(filter_spec, symbolize_keys: !RSpec.configuration.facterdb_string_keys).to_h do |facts|
121-
[Gem::Version.new(facts[:facterversion]), facts]
122+
[Gem::Version.new(facts[facterversion_key]), facts]
122123
end
123124

124125
version, facts = versions.select { |v, _f| strict_requirement =~ v }.max_by { |v, _f| v }

0 commit comments

Comments
 (0)