Skip to content

formerType should be @type: @vocab in context document #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trwnh opened this issue Mar 15, 2025 · 1 comment
Open

formerType should be @type: @vocab in context document #642

trwnh opened this issue Mar 15, 2025 · 1 comment
Assignees
Labels
update-context Context needs updating

Comments

@trwnh
Copy link

trwnh commented Mar 15, 2025

    "formerType": {
      "@id": "as:formerType",
      "@type": "@id"
    },

Problem

"@type": "@id" is base-relative, not vocab-relative; therefore, terms such as the AS2 activity types will not expand. For example, "formerType": "Note" should expand according to the definition of Note, which is https://www.w3.org/ns/activitystreams#Note, but this definition does nothing unless the term formerType is vocab-relative.

Solution

Make formerType vocab-relative by defining it as "@type": "@vocab".

    "formerType": {
      "@id": "as:formerType",
      "@type": "@vocab"
    },
@evanp evanp self-assigned this Mar 21, 2025
@evanp
Copy link
Collaborator

evanp commented Mar 21, 2025

This makes sense to me. It probably makes sense to just patch the context and push a new version, since this appears to be a straight-up bug. It would be backwards-compatible for most uses, except for extremely unusual ones.

@evanp evanp added the update-context Context needs updating label Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update-context Context needs updating
Projects
None yet
Development

No branches or pull requests

2 participants