Skip to content

Get Started button unresponsive in Drawer Welcome #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
7 tasks
jturfanbasis opened this issue Jun 4, 2025 · 4 comments
Open
7 tasks

Get Started button unresponsive in Drawer Welcome #361

jturfanbasis opened this issue Jun 4, 2025 · 4 comments
Labels
bug Something isn't working

Comments

@jturfanbasis
Copy link
Member

jturfanbasis commented Jun 4, 2025

URL or Location

https://docs.webforj.com/webforj/drawerwelcome?

What's wrong or missing?

The “Get Started” button in the Welcome drawer has no click handler, so pressing it produces no action or navigation.

Image

  1. Launch the application.
  2. (If not already visible) Click Open Welcome Page to display the Welcome drawer.
  3. Click the Get Started button.

What should be updated or changed?

I’ve tested the updated code locally and everything functions as expected. If there are no objections, I’ll go ahead and open a pull request to merge the changes.

		welcomeDrawer
				.setPlacement(Placement.BOTTOM)
				.addClassName("welcome__drawer")
				.open();

		Button getStarted = new Button("Get Started");
		getStarted.onClick(e -> {
			welcomeDrawer.close();
		});

		FlexLayout layout = FlexLayout.create(new Img("""
				https://thumb9.shutterstock.com/mosaic_
				250/177370774/1312166426/stock-vector-handshake-heart-icon-stroke-outline-style
				-line-vector-isolate-on-white-background-1312166426.jpg
				"""),
				new H2("Welcome to WebforJ"),
				new Div("Lorem Ipsum is simply dummy text of the printing and typesetting industry"),
				getStarted 
		).vertical()
				.align().center()
				.build();
		welcomeDrawer.add(layout);

Severity

None

Browser

  • Chrome
  • Firefox
  • Safari
  • Microsoft Edge
  • Brave
  • Opera
  • Other

Additional context

No response

@jturfanbasis jturfanbasis added the bug Something isn't working label Jun 4, 2025
@EHandtkeBasis
Copy link
Member

I tested your proposed code locally and everything seems to be fine for me.

@jturfanbasis
Copy link
Member Author

I tested your proposed code locally and everything seems to be fine for me.

Hi Eric, I've attached screen recording.

Screen.Recording.2025-06-11.084639.mp4

@EHandtkeBasis
Copy link
Member

I tested your proposed code locally and everything seems to be fine for me.

Hi Eric, I've attached screen recording.

Screen.Recording.2025-06-11.084639.mp4

Sorry i think there has been a misunderstanding. My comment was meant to be read as i tested your proposed changes as you asked if there are objections. I was not intending to say the unchanged code has a working button.

@jturfanbasis
Copy link
Member Author

@EHandtkeBasis Got it, thanks for clearing that up, Eric. Let me know if any further changes are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants