Skip to content

AWS deployment docs are incorrect/outdated #11541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Zev18 opened this issue Apr 27, 2025 · 4 comments · May be fixed by #11551
Open

AWS deployment docs are incorrect/outdated #11541

Zev18 opened this issue Apr 27, 2025 · 4 comments · May be fixed by #11551
Labels
good first issue Good for newcomers help wanted Issues looking for someone to run with them! improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes)

Comments

@Zev18
Copy link

Zev18 commented Apr 27, 2025

📚 Subject area/topic

Deployment guides -> aws

📋 Page(s) affected (or suggested, for new content)

https://docs.astro.build/en/guides/deploy/aws/#aws-amplify

📋 Description of content that is out-of-date or incorrect

The deployment guide for AWS Amplify is inconsistent with aws's own guide. Following the current guide on the astro docs does not work, resulting in the error
!!! CustomerError: Failed to find the deploy-manifest.json file in the build output. Please verify that it exists within the "baseDirectory" specified in your buildSpec. If it's not there, we will also check the .amplify-hosting directory as a fallback. When using a framework adapter for hosting on Amplify, double-check that the adapter settings are correct.

🖥️ Reproduction in StackBlitz (if reporting incorrect content or code samples)

No response

@Zev18 Zev18 added the improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) label Apr 27, 2025
@sarah11918
Copy link
Member

Thank you for letting us know! Are you able to provide specifics to direct our attention to what is wrong? For example, do we have one step/command wrong, or has AWS completely changed how they do things and the guide is totally out of date? 😄 This will help us make sure we're finding exactly what you intend to point out.

This sounds like a great first issue for someone to compare the two documents and update ours to match!

@sarah11918 sarah11918 added good first issue Good for newcomers help wanted Issues looking for someone to run with them! labels Apr 28, 2025
@Zev18
Copy link
Author

Zev18 commented Apr 28, 2025

I don't think you guys have a specific step wrong. I'm kind of new to all this myself so I'm not quite sure, but it seems like AWS has made a change on their end, and now promote deploying astro apps as SSRs with the 3rd party adapter rather than as a static site. So I think the entire section on Amplify is out of date.

I would be happy to tackle this as a first issue, since I managed to get my app deployed successfully in the end, but if we want to keep instructions for how to deploy as a static site, I won't be much help. I still don't know how to do that, or if it's even possible anymore. I've asked about this on the Astro discord, but haven't gotten any answers.

@sarah11918
Copy link
Member

It would be great if you'd like to take what worked for you and make sure we have a working "Deploy an on-demand rendered site with an adapter" section! Maybe the other stuff is still valid for static sites? Maybe all we're missing is proper SSR guidance?

@Zev18
Copy link
Author

Zev18 commented Apr 28, 2025

I can't speak for the s3 sections, I'm assuming their still correct. But the current amplify instructions are no longer enough for deploying even a static site. I'll make a new pull request for adding a new section for deploying SSR on amplify.

@Zev18 Zev18 linked a pull request Apr 28, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Issues looking for someone to run with them! improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants