Merge pull request #14335 from woocommerce/issue/WOOMOB-871-tax-class-room-crash

Fix crash when tax classes are duplicated

Author: hichamboushaba

libs/fluxc-plugin/src/main/kotlin/org/wordpress/android/fluxc/persistence/dao/TaxClassDao.kt

@@ -2,6 +2,7 @@ package org.wordpress.android.fluxc.persistence.dao
 
 import androidx.room.Dao
 import androidx.room.Insert
+import androidx.room.OnConflictStrategy
 import androidx.room.Query
 import androidx.room.Transaction
 import org.wordpress.android.fluxc.model.LocalOrRemoteId.LocalId
@@ -31,6 +32,6 @@ internal abstract class TaxClassDao {
     )
     protected abstract suspend fun deleteAll(siteId: LocalId): Int
 
-    @Insert
+    @Insert(onConflict = OnConflictStrategy.REPLACE)
     protected abstract suspend fun insertAll(classes: List<WCTaxClassModel>)
 }

libs/fluxc-plugin/src/test/java/org/wordpress/android/fluxc/persistence/dao/TaxClassDaoTest.kt

@@ -121,4 +121,17 @@ class TaxClassDaoTest {
         val otherSiteResult = sut.getTaxClasses(LocalId(999))
         assertThat(otherSiteResult).containsExactly(differentSiteTaxClass)
     }
+
+    @Test
+    fun `when there are duplicate tax classes, replaceAll keeps the last one`() = runTest {
+        // given
+        val taxClasses = listOf(sampleTaxClass1, sampleTaxClass2, sampleTaxClass1)
+        sut.replaceAll(site.localId(), taxClasses)
+
+        // when
+        val result = sut.getTaxClasses(site.localId())
+
+        // then
+        assertThat(result).containsExactlyInAnyOrderElementsOf(listOf(sampleTaxClass1, sampleTaxClass2))
+    }
 }