New DBAction to create primary key constraint from index (#901)

Relates to #742

Author: kvch

pkg/migrations/dbactions.go

@@ -175,6 +175,28 @@ func (a *addConstraintUsingUniqueIndexAction) Execute(ctx context.Context) error
 	return err
 }
 
+type addPrimaryKeyAction struct {
+	conn      db.DB
+	table     string
+	indexName string
+}
+
+func NewAddPrimaryKeyAction(conn db.DB, table, indexName string) *addPrimaryKeyAction {
+	return &addPrimaryKeyAction{
+		conn:      conn,
+		table:     table,
+		indexName: indexName,
+	}
+}
+
+func (a *addPrimaryKeyAction) Execute(ctx context.Context) error {
+	_, err := a.conn.ExecContext(ctx, fmt.Sprintf("ALTER TABLE %s ADD PRIMARY KEY USING INDEX %s",
+		pq.QuoteIdentifier(a.table),
+		pq.QuoteIdentifier(a.indexName),
+	))
+	return err
+}
+
 // dropFunctionAction is a DBAction that drops a function and all of its dependencies (cascade).
 type dropFunctionAction struct {
 	conn      db.DB

pkg/migrations/op_create_constraint.go

@@ -6,8 +6,6 @@ import (
 	"context"
 	"fmt"
 
-	"github.com/lib/pq"
-
 	"github.com/xataio/pgroll/pkg/backfill"
 	"github.com/xataio/pgroll/pkg/db"
 	"github.com/xataio/pgroll/pkg/schema"
@@ -137,10 +135,7 @@ func (o *OpCreateConstraint) Complete(ctx context.Context, l Logger, conn db.DB,
 			return err
 		}
 	case OpCreateConstraintTypePrimaryKey:
-		_, err := conn.ExecContext(ctx, fmt.Sprintf("ALTER TABLE %s ADD PRIMARY KEY USING INDEX %s",
-			pq.QuoteIdentifier(o.Table),
-			pq.QuoteIdentifier(o.Name),
-		))
+		err := NewAddPrimaryKeyAction(conn, o.Table, o.Name).Execute(ctx)
 		if err != nil {
 			return err
 		}