From e96d0aabf738230aaf5b4701987b5fc6d0683f1c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicolas=20Herv=C3=A9?= Date: Thu, 7 Jul 2022 10:50:13 +0200 Subject: [PATCH 1/3] file name coherent with class name (upper/lower case) --- .../twitter/clientlib/model/{URLFields.java => UrlFields.java} | 0 .../com/twitter/clientlib/model/{URLImage.java => UrlImage.java} | 0 .../clientlib/model/{URLFieldsTest.java => UrlFieldsTest.java} | 0 .../clientlib/model/{URLImageTest.java => UrlImageTest.java} | 0 4 files changed, 0 insertions(+), 0 deletions(-) rename src/main/java/com/twitter/clientlib/model/{URLFields.java => UrlFields.java} (100%) rename src/main/java/com/twitter/clientlib/model/{URLImage.java => UrlImage.java} (100%) rename src/test/java/com/twitter/clientlib/model/{URLFieldsTest.java => UrlFieldsTest.java} (100%) rename src/test/java/com/twitter/clientlib/model/{URLImageTest.java => UrlImageTest.java} (100%) diff --git a/src/main/java/com/twitter/clientlib/model/URLFields.java b/src/main/java/com/twitter/clientlib/model/UrlFields.java similarity index 100% rename from src/main/java/com/twitter/clientlib/model/URLFields.java rename to src/main/java/com/twitter/clientlib/model/UrlFields.java diff --git a/src/main/java/com/twitter/clientlib/model/URLImage.java b/src/main/java/com/twitter/clientlib/model/UrlImage.java similarity index 100% rename from src/main/java/com/twitter/clientlib/model/URLImage.java rename to src/main/java/com/twitter/clientlib/model/UrlImage.java diff --git a/src/test/java/com/twitter/clientlib/model/URLFieldsTest.java b/src/test/java/com/twitter/clientlib/model/UrlFieldsTest.java similarity index 100% rename from src/test/java/com/twitter/clientlib/model/URLFieldsTest.java rename to src/test/java/com/twitter/clientlib/model/UrlFieldsTest.java diff --git a/src/test/java/com/twitter/clientlib/model/URLImageTest.java b/src/test/java/com/twitter/clientlib/model/UrlImageTest.java similarity index 100% rename from src/test/java/com/twitter/clientlib/model/URLImageTest.java rename to src/test/java/com/twitter/clientlib/model/UrlImageTest.java From 5533da8225a5315c1993de5088ea4e75b0eb1be4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicolas=20Herv=C3=A9?= Date: Thu, 7 Jul 2022 11:06:14 +0200 Subject: [PATCH 2/3] patch issue #30 --- src/main/java/com/twitter/clientlib/model/User.java | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/main/java/com/twitter/clientlib/model/User.java b/src/main/java/com/twitter/clientlib/model/User.java index 5dc06f7..29fedc6 100644 --- a/src/main/java/com/twitter/clientlib/model/User.java +++ b/src/main/java/com/twitter/clientlib/model/User.java @@ -582,6 +582,14 @@ public static void validateJsonObject(JsonObject jsonObj) throws IOException { if (jsonObj.get("profile_image_url") != null && !jsonObj.get("profile_image_url").isJsonPrimitive()) { throw new IllegalArgumentException(String.format("Expected the field `profile_image_url` to be a primitive type in the JSON string but got `%s`", jsonObj.get("profile_image_url").toString())); } + + // Patch issue #30 + if (jsonObj.get("profile_image_url") != null) { + if (jsonObj.get("profile_image_url").getAsString().isBlank()) { + jsonObj.remove("profile_image_url"); + } + } + // validate the optional field `public_metrics` if (jsonObj.getAsJsonObject("public_metrics") != null) { UserPublicMetrics.validateJsonObject(jsonObj.getAsJsonObject("public_metrics")); From e0b11a84f866c932094f4ae3dad4b07f5094c948 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicolas=20Herv=C3=A9?= Date: Fri, 8 Jul 2022 10:23:10 +0200 Subject: [PATCH 3/3] my version until issue #30 is fixed in the API --- .gitignore | 5 ++++- pom.xml | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index ce22cb4..689f3e7 100644 --- a/.gitignore +++ b/.gitignore @@ -26,4 +26,7 @@ target .gradle build - +#eclipse +.classpath +.project +.settings diff --git a/pom.xml b/pom.xml index 0a61691..c3e1c80 100644 --- a/pom.xml +++ b/pom.xml @@ -5,7 +5,7 @@ twitter-api-java-sdk jar twitter-api-java-sdk - 2.0.1 + 2.0.1-nrv https://github.com/twitterdev/twitter-api-java-sdk Twitter API v2 available endpoints