fixed redundant defer in sessionCore.closeOnce (#1817)

asmyasnikov · web-flow · commit 333e66323297 · 2025-07-06T12:06:20.000+03:00
diff --git a/internal/query/session_core.go b/internal/query/session_core.go
@@ -213,9 +213,9 @@ func (core *sessionCore) attach(ctx context.Context) (finalErr error) {
 	}
 
 	core.closeOnce = sync.OnceFunc(func() {
-		core.SetStatus(StatusClosed)
 		defer close(core.done)
 		defer cancelAttach()
+		core.SetStatus(StatusClosed)
 	})
 
 	if markGoroutineWithLabelNodeIDForAttachStream {

Original file line number	Diff line number	Diff line change
`@@ -213,9 +213,9 @@ func (core *sessionCore) attach(ctx context.Context) (finalErr error) {`
`213`	`213`	`}`
`214`	`214`
`215`	`215`	`core.closeOnce = sync.OnceFunc(func() {`
`216`		`- core.SetStatus(StatusClosed)`
`217`	`216`	`defer close(core.done)`
`218`	`217`	`defer cancelAttach()`
	`218`	`+ core.SetStatus(StatusClosed)`
`219`	`219`	`})`
`220`	`220`
`221`	`221`	`if markGoroutineWithLabelNodeIDForAttachStream {`