Skip to content

Commit 87c9962

Browse files
committed
This Shutdown() is redundant with the one in clientPromise.shutdown(). When capnproto#348 was filed, this was a close() on the done channel instead of a call to ClientHook.Shutdown, but became the latter after merging calls and refs -- done was for the former, Shutdown() for the latter. I'm still not 100% sure why this used to be non-deterministic.
1 parent 13883e4 commit 87c9962

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

capability.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -760,9 +760,6 @@ func (cp *clientPromise) fulfill(c Client) {
760760
return
761761
}
762762

763-
// Client still had references, so we're responsible for shutting it down.
764-
defer cp.h.Shutdown()
765-
766763
rh, l = resolveHook(cp.h, l) // swaps mutex on cp.h for mutex on rh
767764
if rh != nil {
768765
l.Value().refs += refs

0 commit comments

Comments
 (0)