Skip to content

Commit 1d5e20f

Browse files
committed
Fix config merging
1 parent 2a237f2 commit 1d5e20f

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

src/zenml/config/step_configurations.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -261,6 +261,8 @@ def apply_pipeline_configuration(
261261
"failure_hook_source",
262262
"success_hook_source",
263263
"substitutions",
264+
"environment",
265+
"secrets",
264266
},
265267
exclude_none=True,
266268
)
@@ -272,10 +274,16 @@ def apply_pipeline_configuration(
272274
"failure_hook_source",
273275
"success_hook_source",
274276
"substitutions",
277+
"environment",
278+
"secrets",
275279
},
276280
exclude_none=True,
277281
)
278282

283+
original_values["secrets"] = pipeline_values.get(
284+
"secrets", []
285+
) + original_values.get("secrets", [])
286+
279287
updated_config = self.model_copy(update=pipeline_values, deep=True)
280288
return update_model(updated_config, original_values)
281289
else:

src/zenml/zen_server/template_execution/utils.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,15 +48,11 @@
4848
validate_stack_is_runnable_from_server,
4949
)
5050
from zenml.stack.flavor import Flavor
51-
<<<<<<< HEAD
5251
from zenml.utils import (
53-
dict_utils,
52+
pydantic_utils,
5453
requirements_utils,
5554
settings_utils,
5655
)
57-
=======
58-
from zenml.utils import pydantic_utils, requirements_utils, settings_utils
59-
>>>>>>> develop
6056
from zenml.zen_server.auth import AuthContext, generate_access_token
6157
from zenml.zen_server.template_execution.runner_entrypoint_configuration import (
6258
RunnerEntrypointConfiguration,

0 commit comments

Comments
 (0)