drivers: dac: silabs_vdac implementation #93677

silabs-BastienB · 2025-07-24T15:35:27Z

The goal of this PR is to enable the use of the DAC driver for series 2 devices.
This PR does the following:

Fix the clock branch bindings.
Import sl_hal_vdac in hal_silabs/simplicity_sdk.
Enables the hal_silabs VDAC module to be compiled for series 2.
Defines a compatible binding which can be used for series 2 parts that have a VDAC peripheral.
Instantiates the xg2x parts with a VDAC peripheral with a VDAC node in their respective part dtsi.
Implements the DAC driver compatible with silabs,vdac.
Adds support for the DAC driver in the relevant series 2 development kits and radio boards.
Extends the dac_api and dac_loopback tests for xg23 and xg24 boards.

asmellby

Thanks for this! I've got a few comments, nothing major.

soc/silabs/Kconfig

modules/hal_silabs/simplicity_sdk/CMakeLists.txt

dts/bindings/dac/silabs,vdac.yaml

drivers/dac/Kconfig.silabs_vdac

drivers/dac/dac_silabs_vdac.c

tests/drivers/dac/dac_api/src/test_dac.c

tests/drivers/dac/dac_loopback/src/test_dac.c

dts/arm/silabs/xg23/xg23.dtsi

Martinhoff-maker

Only minor comments, otherwise LGTM.
Don't forget to add a commit where you modify west.yml to point the corresponding hal_silabs pull request.
edit: also don't forget to take a look at sonarqube issue.

dts/arm/silabs/xg24/xg24.dtsi

drivers/dac/dac_silabs_vdac.c

github-actions · 2025-07-28T16:22:38Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

jhedberg · 2025-08-06T15:47:52Z

The west.yml change will need to be coordinated with #92808, since that one bumps hal_silabs to latest main whereas this bumps it to main~2

Updated CLOCK_BRANCH bindings to stay in sync with the enum sl_clock_branch_t in the Silicon Labs HAL. Signed-off-by: Bastien Beauchamp <[email protected]>

This enables Silabs Series 2 HAL source files for the Silabs VDAC module to be compiled when the SOC_SILABS_ACMP configuration is selected. Signed-off-by: Bastien Beauchamp <[email protected]>

Generates bindings that define VDAC auxiliary output. These bindings can be used in devicetree sources to configure the aux-output property. Signed-off-by: Bastien Beauchamp <[email protected]>

Defines bindings that are compatible with Silabs VDAC. Reference your part's design book when configuring values for the properties. Signed-off-by: Bastien Beauchamp <[email protected]>

This implements the DAC driver for silabs VDAC peripherals using the silabs,vdac compatible binding. Signed-off-by: Bastien Beauchamp <[email protected]>

Defines a VDAC node for xg23 and xg24 parts, which are all compatible with the silabs,vdac binding. Signed-off-by: Bastien Beauchamp <[email protected]>

Set status to okay for VDAC nodes for xg23 and xg24 boards. Signed-off-by: Bastien Beauchamp <[email protected]>

The xg24_dk2601b, xg24_ek2703a, xg23_rb4210a and xg24_rb4187c board yaml files were updated to support the DAC driver. Signed-off-by: Bastien Beauchamp <[email protected]>

Add board overlays and defines to the test sources files to execute the dac_api and dac_loopback tests on xg23_rb4210a, xg24_dk2601b, xg24_ek2703a and xg24_rb4187c. Signed-off-by: Bastien Beauchamp <[email protected]>

sonarqubecloud · 2025-08-07T12:46:37Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

jhedberg · 2025-08-07T15:51:51Z

@martinjaeger could you please have another look?

silabs-BastienB force-pushed the drivers/dac/silabs_vdac-implementation branch from bc44d3c to b740944 Compare July 24, 2025 19:15

asmellby reviewed Jul 25, 2025

View reviewed changes

asmellby changed the title ~~Drivers: comparator: silabs_vdac implementation~~ drivers: dac: silabs_vdac implementation Jul 25, 2025

asmellby reviewed Jul 25, 2025

View reviewed changes

dts/arm/silabs/xg23/xg23.dtsi Outdated Show resolved Hide resolved

silabs-BastienB force-pushed the drivers/dac/silabs_vdac-implementation branch 3 times, most recently from ce40dd9 to 076477a Compare July 28, 2025 13:24

Martinhoff-maker reviewed Jul 28, 2025

View reviewed changes

dts/arm/silabs/xg24/xg24.dtsi Show resolved Hide resolved

drivers/dac/dac_silabs_vdac.c Outdated Show resolved Hide resolved

drivers/dac/dac_silabs_vdac.c Outdated Show resolved Hide resolved

silabs-BastienB force-pushed the drivers/dac/silabs_vdac-implementation branch from 076477a to 188c5a1 Compare July 28, 2025 16:21

github-actions bot added manifest manifest-hal_silabs DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Jul 28, 2025

silabs-BastienB force-pushed the drivers/dac/silabs_vdac-implementation branch from 188c5a1 to 93370f3 Compare July 28, 2025 16:47

github-actions bot removed manifest manifest-hal_silabs DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Jul 28, 2025

silabs-BastienB force-pushed the drivers/dac/silabs_vdac-implementation branch from 93370f3 to 9219013 Compare July 29, 2025 04:38

github-actions bot added manifest manifest-hal_silabs DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Jul 29, 2025

silabs-BastienB force-pushed the drivers/dac/silabs_vdac-implementation branch from 9219013 to fdd8f3d Compare July 29, 2025 05:43

silabs-BastienB marked this pull request as ready for review July 29, 2025 06:22

zephyrbot added area: DAC Digital-to-Analog Converter area: Clock Control platform: Silabs Silicon Labs labels Jul 29, 2025

zephyrbot requested review from jerome-pouiller, jhedberg, martinjaeger and mnkp July 29, 2025 06:23

github-actions bot removed the DNM (manifest) This PR should not be merged (controlled by action-manifest) label Aug 6, 2025

jerome-pouiller previously approved these changes Aug 6, 2025

View reviewed changes

asmellby previously approved these changes Aug 6, 2025

View reviewed changes

Martinhoff-maker previously approved these changes Aug 6, 2025

View reviewed changes

jhedberg previously approved these changes Aug 6, 2025

View reviewed changes

silabs-BastienB added 9 commits August 7, 2025 08:42

include: zephyr: dt-bindings: clock: silabs: fix clock branch

101f441

Updated CLOCK_BRANCH bindings to stay in sync with the enum sl_clock_branch_t in the Silicon Labs HAL. Signed-off-by: Bastien Beauchamp <[email protected]>

modules: hal_silabs: enable VDAC module in series 2 hal

4e07caf

This enables Silabs Series 2 HAL source files for the Silabs VDAC module to be compiled when the SOC_SILABS_ACMP configuration is selected. Signed-off-by: Bastien Beauchamp <[email protected]>

include: zephyr: dt-bindings: dac: silabs: generate VDAC

5701317

Generates bindings that define VDAC auxiliary output. These bindings can be used in devicetree sources to configure the aux-output property. Signed-off-by: Bastien Beauchamp <[email protected]>

dts: bindings: dac: define silabs,vdac bindings

0cf12ab

Defines bindings that are compatible with Silabs VDAC. Reference your part's design book when configuring values for the properties. Signed-off-by: Bastien Beauchamp <[email protected]>

drivers: dac: implement the silabs_vdac compatible driver

2c577cb

This implements the DAC driver for silabs VDAC peripherals using the silabs,vdac compatible binding. Signed-off-by: Bastien Beauchamp <[email protected]>

dts: arm: silabs: instantiate VDAC nodes for xg2x parts

ca5845d

Defines a VDAC node for xg23 and xg24 parts, which are all compatible with the silabs,vdac binding. Signed-off-by: Bastien Beauchamp <[email protected]>

boards: silabs: enable VDAC nodes for xg2x boards

fa2e0cf

Set status to okay for VDAC nodes for xg23 and xg24 boards. Signed-off-by: Bastien Beauchamp <[email protected]>

boards: silabs: update board support for DAC driver

aaa9632

The xg24_dk2601b, xg24_ek2703a, xg23_rb4210a and xg24_rb4187c board yaml files were updated to support the DAC driver. Signed-off-by: Bastien Beauchamp <[email protected]>

tests: drivers: dac: add xg23 and xg24 boards to dac tests

d317964

Add board overlays and defines to the test sources files to execute the dac_api and dac_loopback tests on xg23_rb4210a, xg24_dk2601b, xg24_ek2703a and xg24_rb4187c. Signed-off-by: Bastien Beauchamp <[email protected]>

silabs-BastienB dismissed stale reviews from jhedberg, Martinhoff-maker, asmellby, and jerome-pouiller via d317964 August 7, 2025 12:42

silabs-BastienB force-pushed the drivers/dac/silabs_vdac-implementation branch from 087566f to d317964 Compare August 7, 2025 12:42

github-actions bot removed manifest manifest-hal_silabs labels Aug 7, 2025

asmellby approved these changes Aug 7, 2025

View reviewed changes

Martinhoff-maker approved these changes Aug 7, 2025

View reviewed changes

jerome-pouiller approved these changes Aug 7, 2025

View reviewed changes

jhedberg approved these changes Aug 7, 2025

View reviewed changes

martinjaeger approved these changes Aug 7, 2025

View reviewed changes

cfriedt merged commit 16298e9 into zephyrproject-rtos:main Aug 8, 2025
29 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

drivers: dac: silabs_vdac implementation #93677

drivers: dac: silabs_vdac implementation #93677

Uh oh!

silabs-BastienB commented Jul 24, 2025 •

edited

Loading

Uh oh!

asmellby left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Martinhoff-maker left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jul 28, 2025 •

edited

Loading

Uh oh!

jhedberg commented Aug 6, 2025

Uh oh!

sonarqubecloud bot commented Aug 7, 2025

Uh oh!

jhedberg commented Aug 7, 2025

Uh oh!

Uh oh!

Uh oh!

drivers: dac: silabs_vdac implementation #93677

drivers: dac: silabs_vdac implementation #93677

Uh oh!

Conversation

silabs-BastienB commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

asmellby left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Martinhoff-maker left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jhedberg commented Aug 6, 2025

Uh oh!

sonarqubecloud bot commented Aug 7, 2025

Quality Gate passed

Uh oh!

jhedberg commented Aug 7, 2025

Uh oh!

Uh oh!

Uh oh!

silabs-BastienB commented Jul 24, 2025 •

edited

Loading

Martinhoff-maker left a comment •

edited

Loading

github-actions bot commented Jul 28, 2025 •

edited

Loading