Fix/android secure storage plugin setup #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be imported into the assets folder - previously, we were encountering build issues where when secure storage wasn't enabled, we weren't able to toggle this plugin off as it was in the packages folder and immutable; this should fix this issue
…rror and open our warning popup to indicate that using uppercase characters in the URL scheme may lead to deeplinking issues on certain platforms (e.g. Android)
Deploying sequence-unity with
|
| Latest commit: |
7d2d256
|
| Status: | 🚫 Build failed. |
|
Looks good to me! One minor question: The plugin is currently enabled for all platforms. Would it be better only to include it for Android in the default import settings? What do you think? |
andygruening
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of including the Android secure storage plugin in Packages, we now import it in Assets via Samples~. This is done so that the plugin can be imported in a mutable state. This allows integrators to build without it or with it based on their SequenceConfig (as set by AndroidDependencyManager editor build script).
Version Increment
Please ensure you have incremented the package version in the package.json as necessary.
Docs Checklist
Please ensure you have addressed documentation updates if needed as part of this PR: