Bugfix/ssrf s3 endpoint validation #187
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent SSRF via S3 Endpoint Validation in Storage Configuration
Summary
This PR fixes a Server-Side Request Forgery (SSRF) vulnerability in the storage configuration logic by validating the S3 endpoint before instantiating the S3 client. Only allow-listed, trusted S3 endpoints are now permitted.
What Was Changed
ALLOWED_S3_ENDPOINTS
) ins3-helper.ts
for trusted S3 endpoints (e.g., official AWS S3 endpoints).isAllowedS3Endpoint
) to check the endpoint against the allow-list.Security Impact
How to Adjust
ALLOWED_S3_ENDPOINTS
array ins3-helper.ts
.Closes #186
This patch closes a high-severity SSRF vector and aligns with best practices for secure cloud storage integrations.