Fix #203: Info disclosure #208
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom BaseUser to SuperAdmin
…TE MEMBER TO ORGANIZATION via 'Add Member' functionality
… Reference (IDOR) Vulnerability on 'Account Settings --> Organizations' exposing organization & Admin PII
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recommended fix for security issue #203 :
NB: This requires no coding fix, just do disable / deprecate API Endpoint and Comment out affected code portion.
Since the "MarketPlace Model" functionality does not require any API calls to another user's profile (no need for an API call to CEO's profile)
1- Commenting out that API call to /api/user/(the 6 IDs called) in the code base is what is required to fix this vulnerability.
2- Also, disabling the API endpoint "/api/user/ID" is required from the API Collection since /api/users/ID performs the same task.
In a nutshell, remove (disable/depreciate) the /api/user/ID from the API collection and comment out that portion in the "MarketModel" code base (to avoid default calls to those 6 api endpoints)