Skip to content

fix: prevent closing parents on hide #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prevent closing parents on hide #1064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions docs/.vitepress/components/SubMenuExample.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
Click me
</button>

<template #popper>
<template #popper="{ hide }">
<div class="px-4 py-1">
Sub menus:
</div>
Expand All @@ -62,7 +62,7 @@
Sub menu >
</button>

<template #popper>
<template #popper="{ hide: hideLevel2 }">
<VDropdown
v-for="m in 5"
:key="m"
Expand All @@ -73,14 +73,33 @@
Option {{ m }} >
</button>

<template #popper>
<div class="px-6 py-2">
<template #popper="{ hide: hideLevel3 }">
<div class="px-6 py-2 text-center">
Hello
<button
class="rounded hover:bg-red-100 px-4 py-2 w-full mt-2"
@click="hideLevel3"
>
Hide
</button>
</div>
</template>
</VDropdown>
<button
class="rounded hover:bg-red-100 px-4 py-2 w-full text-left"
@click="hideLevel2"
>
Hide
</button>
</template>
</VDropdown>

<button
class="rounded hover:bg-red-100 px-4 py-2 w-full text-left"
@click="hide"
>
Hide
</button>
</template>
</VDropdown>
</div>
Expand Down
7 changes: 6 additions & 1 deletion packages/floating-vue/src/components/Popper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1090,7 +1090,12 @@ function handleGlobalClose (event: PopperEvent, touch: boolean) {
for (let i = shownPoppers.length - 1; i >= 0; i--) {
const popper = shownPoppers[i]
try {
const contains = popper.containsGlobalTarget = popper.mouseDownContains || popper.popperNode().contains(event.target)
const childrenContains = Array.from(popper.shownChildren).some(id => {
const child = shownPoppers.find(p => p.randomId === id)
return child && child.popperNode().contains(event.target)
})

const contains = popper.containsGlobalTarget = popper.mouseDownContains || popper.popperNode().contains(event.target) || childrenContains
popper.pendingHide = false

// Delay so that close directive has time to set values (closeAllPopover, closePopover)
Expand Down