SC: Implement new sync call host functions #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
requested changes
May 1, 2025
| * | ||
| * @tparam T - Type of call data, must be serializable by `pack(...)` | ||
| * @param receiver - The name of the account this call is intended for | ||
| * @param flags - The flags |
There was a problem hiding this comment.
* @param flags - flags (bits) representing blockchain level requirements about
* the call. Currently LSB bit indicates read-only. All other bits
* are reserved to be 0
Although, since this is suppose to be an easy to use wrapper. I think this should just be a bool read_only. And call can create the correct flags.
There was a problem hiding this comment.
This call class is low level. I chose to keep it closer to the host function parameters, while make the to-be-implemented wrapper to take read_only argument.
There was a problem hiding this comment.
I think about it more and agree with you. I have changed to take in read_only and another flag no_op_if_receiver_not_support_sync_call as parameters. Thanks.
There was a problem hiding this comment.
I have changed the bools to enums in #351. I have updated the comment there.
…structor; enforce no_op_if_receiver_no_support_sync_call
…t_support_sync_call
heifner
reviewed
May 5, 2025
heifner
approved these changes
May 22, 2025
spoonincode
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This is the first PR of sync call support in CDT. Its purpose is to build the basic infrastructure and get things moving. More changes are in future PRs.
The PR implements the new host functions
call(),get_call_return_value(),get_call_data(), andset_call_return_value(). A simple test showscall()andget_call_return_value()can get intonodeoshost side and return back results.get_call_data()andset_call_return_value()cannot be tested at the moment.Resolves #342
API Changes
Documentation Additions