-
Notifications
You must be signed in to change notification settings - Fork 457
Implement graceful shutdown timeout period #4540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
d99ac94
to
23d4cb3
Compare
@mattchenderson @fabiocav - as per @jviau suggestion, I've switched over to a grace period approach. We will give the host 2 seconds to gracefully shut down, if it does not we kill the process. The behaviour on pressing After we address the bug in the host, the host should shutdown with the 2 seconds pretty much every time so there shouldn't be an major impact. On the plus side, if anything ever occurs where the host does take longer, thats not something we need to worry about for local dev with the graceful timeout period. |
Issue describing the changes in this PR
resolves #4355
Pull request checklist
release_notes.md
Additional information