Skip to content

Particle attractors #16541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 30, 2025
Merged

Particle attractors #16541

merged 5 commits into from
Apr 30, 2025

Conversation

deltakosh
Copy link
Contributor

No description provided.

@deltakosh deltakosh enabled auto-merge (squash) April 29, 2025 21:10
@bjsplat
Copy link
Collaborator

bjsplat commented Apr 29, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 29, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 29, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16541/merge/testResults/webgl2playwright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 29, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16541/merge/testResults/webgpuplaywright/index.html

Popov72
Popov72 approved these changes Apr 30, 2025
View reviewed changes
Copy link
Contributor

@Popov72 Popov72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should update the visual test, because we mainly see the background. I'm afraid we may not detect a bug in the future because too few pixels are affected by the new code.

@deltakosh deltakosh merged commit 55aea71 into master Apr 30, 2025
17 checks passed
@deltakosh deltakosh deleted the particle-attractors branch April 30, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Popov72 Popov72 Popov72 approved these changes

Assignees
No one assigned
Labels
new feature particles
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deltakosh @bjsplat @Popov72