fix(cmake): Use CMAKE_BINARY_DIR for installation path #1510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace relative path with CMAKE_BINARY_DIR in Install.cmake to ensure consistent installation behavior across different platforms and support out-of-source builds. This change follows CMake best practices by keeping generated files within the build directory.
|
I'm not opposed to this change, but I don't see a problem on macOS. Can you elaborate on what you are seeing? |
|
When I build the 'install target' in xcode, I get the following error. And I saw other people also mentioned this problem, link 
|
Hmm, I've never built the install target from XCode. Maybe this fix will make it so that you can pass relative paths to the prefix? Like this |
bghgary
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace relative path with CMAKE_BINARY_DIR in Install.cmake to ensure consistent installation behavior across different platforms.
fix fail in macOS.