Skip to content

2309-action-items-make-them-as-a-separate-tab #2310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 12, 2025

Conversation

skywinder
Copy link
Collaborator

@skywinder skywinder commented May 5, 2025

implementation or tab for action items. Screenshot attached.

fix #2309

image

Copy link

vercel bot commented May 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
omi ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2025 9:52pm

@smian1
Copy link
Collaborator

smian1 commented May 6, 2025

@skywinder While this is fine for the conversation. Also need to surface action items on the main menu. Should surface actions items from all the conversations.

@@ -13,7 +13,7 @@ enum ConversationBottomBarMode {
detail // For viewing completed conversations
}

enum ConversationTab { transcript, summary }
enum ConversationTab { transcript, summary, action_items }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we pls have it in lowerCamelCase since dart does not make use of snake_case

@mdmohsin7
Copy link
Member

@skywinder can we not show the action items tab if there are no action items for that specific memory? Because currently if a memory does not have any action items then it is a blank screen which I don't think looks that good. What do you think would be a better way? Not showing the tab or showing some text or illustration instead of the blank screen?

@skywinder
Copy link
Collaborator Author

skywinder commented May 11, 2025

@mdmohsin7 Yes, we can. And probably it's good point.

Just a reminder — it was a quick fix, and right now we don’t have anything in place, and people are complaining.
Later, Nik asked to make it a tab. We can improve more. But need to know when to stop.

I just want to fix it for now, and we can improve it later. Because now it's just don't work at all.

@skywinder
Copy link
Collaborator Author

@mdmohsin7 Hide - is not good idea, i'ts better to have consistent UI, so users knows that's it awailable. Let's just show thats it's empy

@skywinder
Copy link
Collaborator Author

skywinder commented May 11, 2025

@smian1 We’ll do that later — the whole to-do list is already under development.

For now, this is just a quick fix to restore broken functionality. The to-do list needs proper testing, and on the main screen we still have to figure out where to place it.

PS
There’s also Memories, which should be shown there, and many more features in the future (like a calendar view — I already have an idea for that). But let’s take it step by step.

This is an MVP — it just needs to work. I’m just trying to fix what was accidentally broken. It started as a simple one-line fix, and now it’s grown into an epic with tons of features.

@skywinder
Copy link
Collaborator Author

@mdmohsin7 fixed
IMG_1265

@mdmohsin7 mdmohsin7 merged commit facc6cc into main May 12, 2025
2 of 3 checks passed
@mdmohsin7 mdmohsin7 deleted the 2309-action-items-make-them-as-a-separate-tab branch May 12, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flutter flutter work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Action items: Make them as a separate tab
3 participants