-
Notifications
You must be signed in to change notification settings - Fork 813
2309-action-items-make-them-as-a-separate-tab #2310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2309-action-items-make-them-as-a-separate-tab #2310
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@skywinder While this is fine for the conversation. Also need to surface action items on the main menu. Should surface actions items from all the conversations. |
@@ -13,7 +13,7 @@ enum ConversationBottomBarMode { | |||
detail // For viewing completed conversations | |||
} | |||
|
|||
enum ConversationTab { transcript, summary } | |||
enum ConversationTab { transcript, summary, action_items } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we pls have it in lowerCamelCase since dart does not make use of snake_case
@skywinder can we not show the action items tab if there are no action items for that specific memory? Because currently if a memory does not have any action items then it is a blank screen which I don't think looks that good. What do you think would be a better way? Not showing the tab or showing some text or illustration instead of the blank screen? |
@mdmohsin7 Yes, we can. And probably it's good point. Just a reminder — it was a quick fix, and right now we don’t have anything in place, and people are complaining. I just want to fix it for now, and we can improve it later. Because now it's just don't work at all. |
@mdmohsin7 Hide - is not good idea, i'ts better to have consistent UI, so users knows that's it awailable. Let's just show thats it's empy |
@smian1 We’ll do that later — the whole to-do list is already under development. For now, this is just a quick fix to restore broken functionality. The to-do list needs proper testing, and on the main screen we still have to figure out where to place it. PS This is an MVP — it just needs to work. I’m just trying to fix what was accidentally broken. It started as a simple one-line fix, and now it’s grown into an epic with tons of features. |
@mdmohsin7 fixed |
implementation or tab for action items. Screenshot attached.
fix #2309