fix: mark secrets as sensitive (Sensitive: true). #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: Copilot <[email protected]> Signed-off-by: btfhernandez <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: btfhernandez <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: btfhernandez <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR enhances security by marking secret values as sensitive in Terraform schemas and outputs to prevent them from being displayed in logs or CLI output. It also updates documentation to clarify the purpose of the api_account_name parameter.
Key changes:
- Added
Sensitive: trueto all schema fields containing sensitive data (passwords, secrets, file content) - Added
sensitive = trueto Terraform outputs containing secret values - Updated documentation to clarify the role of
api_account_namein authorization
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| terraform/main.tf | Added sensitive flags to outputs and corrected account name reference |
| providers/provider_sdkv2/secrets.go | Marked value, password, text, and file_content fields as sensitive |
| providers/provider_sdkv2/provider.go | Updated description for api_account_name parameter |
| providers/provider_sdkv2/managed_account.go | Marked value field as sensitive in managed account schema |
| providers/provider_sdkv2/common.go | Marked password field as sensitive in managed account schema |
| providers/provider_framework/provider.go | Updated description for api_account_name parameter |
| docs/index.md | Updated documentation for api_account_name parameter |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
Mark secrets as sensitive (Sensitive: true).
According to ticket
https://beyondtrust.atlassian.net/browse/BIPS-28983
Summary of changes: