Skip to content

Adding bento ref #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Adding bento ref #129

wants to merge 19 commits into from

Conversation

vdonkor
Copy link
Collaborator

@vdonkor vdonkor commented May 4, 2023

Modified bento backend

Copy link
Contributor

@michael-fleming michael-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make the following changes:

  1. for all builds can we use "{{ container_build_path }}" for the path parameter - this will make the code more adaptable
  2. for the frontend build can we delete the commented build steps. we won't be using these going forward so we won't need to keep them to uncomment them
  3. can we add the trivy scanning steps for all of the builds. this should match what is done in the backend build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants