added several symbols and footprints #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jharvey
changed the title
…tors_(Headphones)_C707223
|
Sorry I didn't see this sooner but the symbols for extended components should only be in JLCPCB-Extended.kicad_sym becasue the code currently only supports having basic/prefered parts in the other .kicad_sym files and because of the daily updates it also causes tons of merge conflics. Right now I don't really have the time to manually fix you pull request but I might have the time in a couple months but for now if you want me to merge your changes you'll need to move your symbols to JLCPCB-Extended.kicad_sym and revert your changes to Connectors_Buttons, Diode-Packages, Diodes, ICs, and Transformers (.kicad_sym) But otherwise thanks for your hard work :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@CDFER I added 7 segment red LED display, I double checked the below items.
-- This was done in KC8.
-- 3D model installed correctly
-- Draft board uploaded to JLCPCB to validate the part placement is correct.