clc: add clc sync message #483
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jrcastro2
commented
May 16, 2025
•
jrcastro2
commented
jrcastro2
force-pushed
the
add-clc-message
branch
from
d8576a4 to
3fc469d
Compare
ntarocco
reviewed
May 16, 2025
invenio.cfg
Outdated
Comment on lines
520
to
521
| "cds_rdm/records/manage_menu.html" if template == "invenio_app_rdm/records/details/side_bar/manage_menu.html" else template | ||
| for template in DEFAULT_SIDE_BAR_TEMPLATES |
There was a problem hiding this comment.
Is the if condition neede?
There was a problem hiding this comment.
Yes, because the idea is to replace the existing manage_menu.html template only. The goal is to avoid overriding the entire template which we could do, but I simply want to add new data attributes.
jrcastro2
force-pushed
the
add-clc-message
branch
2 times, most recently
from
0d508fb to
179eed5
Compare
kpsherva
reviewed
May 19, 2025
| @@ -38,7 +37,7 @@ class CLCSyncPermissionPolicy(BasePermissionPolicy): | |||
| """Permission policy for CLCSync.""" | |||
|
|
|||
| can_create = [CLCExporter(), Administration(), SystemProcess()] | |||
| can_read = [CLCExporter(), Administration(), SystemProcess()] | |||
| can_read = [CLCExporter(), Administration(), SystemProcess(), AnyUser()] | |||
There was a problem hiding this comment.
why does Any User need to read?
There was a problem hiding this comment.
We need to retrieve if the record is synced or not on each landing page, for any record, for any user, to be able to conditionally display the new banner. @jrcastro2 you can probably remove all the other permissions given the AnyUser.
kpsherva
reviewed
May 19, 2025
kpsherva
reviewed
May 19, 2025
site/cds_rdm/templates/semantic-ui/cds_rdm/records/manage_menu.html
Outdated
Show resolved
Hide resolved
kpsherva
reviewed
May 19, 2025
jrcastro2
force-pushed
the
add-clc-message
branch
from
179eed5 to
5fe2067
Compare
jrcastro2
force-pushed
the
add-clc-message
branch
from
5fe2067 to
4463b1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.