-
Notifications
You must be signed in to change notification settings - Fork 22
CTT support #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
CTT support #282
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds CTT support and upgrades multiple components – both in the storage/cache layer and in many of the process plugins – by replacing integer-based return codes with a new enumerated type (ProcessPlugin::FlowAction). In addition, it introduces new modules (e.g. cache-ctt) to handle offload and export via CTT and adapts many plugin files accordingly.
Reviewed Changes
Copilot reviewed 104 out of 105 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/plugins/storage/cache/.hpp,.cpp | Inlined “inline” keyword for operators and minor refactoring in time/value handling. |
src/plugins/storage/cache-ctt/* | New CTT support code, including controller, remove queue, and extension of the hash table cache. |
src/plugins/process/* | Refactored plugin functions to return ProcessPlugin::FlowAction instead of int, ensuring consistent API calls. |
CMakeLists.txt files | Updated build definitions (e.g. enabling “maybe_virtual”) and linking to new telemetry/CTT libraries. |
Comments suppressed due to low confidence (2)
src/plugins/process/tls/src/tls.cpp:393
- [nitpick] There is commented-out code offering an alternative assignment for rec->version. If this alternative is no longer needed, consider removing it or adding a comment to clarify its purpose to improve code readability.
//rec->version = parser.get_supported_versions().empty() ? parser.get_handshake()->version.version
src/plugins/process/netbios/src/netbios.cpp:83
- The previous implementation incremented total_netbios_packets when adding a NETBIOS extension; however, the new diff omits this counter update. Please verify whether this change is intentional, or if the counter should still be updated to maintain accurate metrics.
total_netbios_packets++;
No description provided.