Fix Hydra integration #189
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noonio
approved these changes
Apr 15, 2025
|
Hey, I just noticed that the golden tests are not as complete as they could be; in particular, the Might be good to re-generate the golden test to be more useful (maybe multiple per variant?) |
Update decoding of SnapshotConfirmed to use the included transactions directly. This is not needed anymore as the API changed. Also, the L2 ledger of hydra is always in ConwayEra now. There is now also a golden file for each server output that the hydra-node sends through the websocket that we can use in tests.
|
@KtorZ I have fixed the golden file and make sure it has at least one transaction: cardano-scaling/hydra#1966 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update decoding of SnapshotConfirmed to use the included transactions directly. This is not needed anymore as the API changed.
Also, the L2 ledger of hydra is always in ConwayEra now.
There is now also a golden file for each server output that the hydra-node sends through the websocket that we can use in tests.
This closes cardano-scaling/hydra#1785