[CHIA-3598] Port easy wallet endpoints to @marshal
#19941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quexington
added
the
Changed
Base automatically changed from
quex.port_get_transaction_memo_to_marshal
to
main
August 13, 2025 16:24
github-actions
bot
added
merge_conflict
Quexington
force-pushed
the
quex.port_easy_wallet_endpoints_to_marshal
branch
from
35b6e10 to
a3082fc
Compare
github-actions
bot
removed
the
merge_conflict
Quexington
force-pushed
the
quex.port_easy_wallet_endpoints_to_marshal
branch
from
303c8f3 to
2f27a63
Compare
Quexington
force-pushed
the
quex.port_easy_wallet_endpoints_to_marshal
branch
from
2f27a63 to
e5e26b1
Compare
altendky
requested changes
Aug 14, 2025
altendky
approved these changes
Aug 14, 2025
|
markelrod
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another PR following #18593
Worth noting that in the
sign_message_by_*endpoints, I've dropped support for"True"and"False"being registered astrueandfalse. We apparently did intentionally support this but I can't fathom why and at the very least it's not compliant with JSON. ("true"and"false"will still register apparently becausestreamablesupports that)