[CHIA-3600] Port send_transaction to @marshal
#19960
Merged
+176
−109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quexington
added
the
Changed
Quexington
changed the title
send_transaction(_multi) to @marshalsend_transaction to @marshal
github-actions
bot
added
coverage-diff
merge_conflict
…ction_s_to_marshal
github-actions
bot
removed
the
merge_conflict
altendky
approved these changes
Aug 18, 2025
markelrod
approved these changes
Aug 18, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another PR following #18593
Funny(?) thing to note is that I guess the client serialization of
extra_conditionswas not at all tested before this PR, so I had to make a small tweak toTransactionEndpointRequestin order to fix what was broken.