Fix build presets with multiple targets #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a build preset from CMakePresets.json contained multiple targets, BuildPreset:get_build_target would concatenate target names into a single string which would be used as a single command line argument. The build system, such as Ninja, would then complain that the specified target is unknown. This change modifies BuildPreset:get_build_target to return a table of targets instead, which is then unpacked after CMake's --target flag. That way, each target is a separate command line argument and the build system executes a proper multi-target build.
bornabesic
force-pushed
the
fix-build-preset-targets
branch
from
51251d7 to
a06fb54
Compare
|
lgtm. Thanks for your contribution |
lceWolf
pushed a commit
to lceWolf/cmake-tools.nvim
that referenced
this pull request
Aug 11, 2025
PR Civitasv#332 introduced handling for multiple targets. Yet, old session data still has the build_target stored as string resulting in an error when trying to unpack the string when forming the --target arg. This PR fixes this issue by converting old session data to the new format, if needed
lceWolf
pushed a commit
that referenced
this pull request
Aug 11, 2025
PR #332 introduced handling for multiple targets. Yet, old session data still has the build_target stored as string resulting in an error when trying to unpack the string when forming the --target arg. This PR fixes this issue by converting old session data to the new format, if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a build preset from CMakePresets.json contained multiple targets,
BuildPreset:get_build_targetwould concatenate target names into a single string which would be used as a single command line argument. The build system, such as Ninja, would then complain that the specified target is unknown.This change modifies
BuildPreset:get_build_targetto return a table of targets instead, which is then unpacked after CMake's--targetflag. That way, each target is a separate command line argument and the build system executes a proper multi-target build.