Skip to content

Dev: cibconfig: Prevent adding Pacemaker remote resources to groups, orders, or colocations #1777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Dev: cibconfig: Prevent adding Pacemaker remote resources to groups, orders, or colocations #1777

wants to merge 1 commit into from

Conversation

liangxin1300
Copy link
Collaborator

@liangxin1300 liangxin1300 commented May 5, 2025 •
edited
Loading

Fix issue #1726

@liangxin1300 liangxin1300 force-pushed the 20250504_prevent_remote_to_container branch from f545c9c to 37b2578 Compare May 6, 2025 03:03
@liangxin1300 liangxin1300 force-pushed the 20250504_prevent_remote_to_container branch from 37b2578 to 684c7b6 Compare May 6, 2025 06:02
@codecov Codecov
Copy link

codecov bot commented May 6, 2025

Codecov Report

Attention: Patch coverage is 84.61538% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.26%. Comparing base (7ca341f) to head (684c7b6).

Files with missing lines Patch % Lines
crmsh/cibconfig.py 84.61% 4 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
integration 54.49% <73.07%> (+0.01%) ⬆️
unit 52.83% <57.69%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/cibconfig.py 65.70% <84.61%> (+0.15%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@liangxin1300
Copy link
Collaborator Author

liangxin1300 commented May 6, 2025 •
edited
Loading

  • Should add new behave test case for pacemaker remote

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@liangxin1300